Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix eav form foreach error #21134 #21135
Conversation
Feb 11, 2019
added some commits
This comment has been minimized.
This comment has been minimized.
Hi @wojtekn. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
This comment has been minimized.
This comment has been minimized.
Wojtek Naruniec seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
magento-engcom-team
added
Component: Eav
Release Line: 2.3
Partner: Mediotype
partners-contribution
labels
Feb 11, 2019
osrecio
self-assigned this
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
wojtekn commentedFeb 11, 2019
Description
PR adds missing initialization for two class variables which can be returned by class methods as parameters of type array. Without this initialization they are return as null what can result in throwing "Invalid argument supplied for foreach()" warning.
Fixed Issues
Manual testing scenarios (*)
Contribution checklist (*)