New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eav form foreach error #21134 #21135

Open
wants to merge 2 commits into
base: 2.3-develop
from

Conversation

Projects
None yet
4 participants
@wojtekn
Copy link
Contributor

wojtekn commented Feb 11, 2019

Description

PR adds missing initialization for two class variables which can be returned by class methods as parameters of type array. Without this initialization they are return as null what can result in throwing "Invalid argument supplied for foreach()" warning.

Fixed Issues

  1. #21134

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 11, 2019

Hi @wojtekn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2

This comment has been minimized.

Copy link
Contributor

magento-cicd2 commented Feb 11, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Wojtek Naruniec seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment