Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Solved swagger response of product attribute option is_default #21164

Merged

Conversation

@mage2pratik
Copy link
Contributor

mage2pratik commented Feb 12, 2019

Original Pull Request

#20913

Fixed Issues (if relevant)

  1. #18525: Incorrect Swager Definition for eav-data-attribute-option-interface

Manual testing scenarios (*)

Example : https://MAGENTO-HOST-NAME/rest/all/V1/products/attributes/country_of_manufacture
For above example URL it will give "is_default": true for the default selected country

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 12, 2019

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 12, 2019

Hi @sidolov, thank you for the review.
ENGCOM-4234 has been created to process this Pull Request

nmalevanec added 2 commits Feb 15, 2019
@magento-engcom-team magento-engcom-team merged commit 7b8ec80 into magento:2.2-develop Feb 18, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
magento-engcom-team pushed a commit that referenced this pull request Feb 18, 2019
…option is_default #21164
@contribution-survey

This comment has been minimized.

Copy link

contribution-survey bot commented Feb 18, 2019

Hi @mage2pratik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.