Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] issue fixed #20919 Email label and email field not aligned from left … #21241

Conversation

@amol2jcommerce
Copy link
Contributor

amol2jcommerce commented Feb 14, 2019

Original Pull Request

#21009
…for reorder of guest user

issue fixed #20919 Email label and email field not aligned from left for reorder of guest user

Manual testing scenarios (*)

  1. Open frontend and order an product as guest customer
  2. open admin panel, open order grid from sales > order
  3. edit same order whatever you purchase
  4. click on reorder button
  5. page will open and will get issue ref screenshot

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
cedarvinda added 2 commits Feb 6, 2019
…for reorder of guest user

issue fixed #20919 Email label and email field not aligned from left for reorder of guest user
_order-account.less updated
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 14, 2019

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar

This comment has been minimized.

Copy link
Contributor

rogyar commented Feb 15, 2019

@magento-engcom-team give me test instance

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 15, 2019

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@rogyar rogyar self-assigned this Feb 15, 2019
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 15, 2019

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-21241.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rogyar
rogyar approved these changes Feb 15, 2019
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 15, 2019

Hi @rogyar, thank you for the review.
ENGCOM-4280 has been created to process this Pull Request

@sdzhepa

This comment has been minimized.

Copy link
Contributor

sdzhepa commented Feb 15, 2019

@magento-engcom-team give me test instance

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 15, 2019

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 15, 2019

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-21241.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sdzhepa

This comment has been minimized.

Copy link
Contributor

sdzhepa commented Feb 19, 2019

@magento-engcom-team give me test instance

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 19, 2019

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 19, 2019

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-21241.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Feb 19, 2019

Hi @sdzhepa, thank you for the review.
ENGCOM-4280 has been created to process this Pull Request

VladimirZaets and others added 2 commits Feb 19, 2019
@contribution-survey

This comment has been minimized.

Copy link

contribution-survey bot commented Feb 22, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit c753b2a into magento:2.2-develop Feb 22, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
magento-engcom-team pushed a commit that referenced this pull request Feb 22, 2019
…d not aligned from left … #21241
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.