Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP] static tests forbid or instead of 21062 #21543

Conversation

@novikor
Copy link
Contributor

novikor commented Mar 1, 2019

Description (*)

Added Squiz.Operators.ValidLogicalOperators PHP-CS rule

Fixed Issues (if relevant)

  1. #21062: Static tests: forbid 'or' instead of '||'

Manual testing scenarios (*)

Just make sure PHP-CS asks you to avoid the literal logical operators

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
@novikor novikor requested a review from orlangur Mar 1, 2019
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Mar 1, 2019

Hi @novikor. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Mar 1, 2019
@pull-request-dashboard-manager pull-request-dashboard-manager bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard Mar 1, 2019
@novikor novikor closed this Mar 1, 2019
@novikor novikor force-pushed the novikor:22-Static-tests-forbid-or-instead-of-21062 branch from 3b74098 to 6ddfc58 Mar 1, 2019
@contribution-survey

This comment has been minimized.

Copy link

contribution-survey bot commented Mar 1, 2019

Hi @novikor, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@pull-request-dashboard-manager pull-request-dashboard-manager bot removed this from Review in Progress in Pull Requests Dashboard Mar 1, 2019
Added Squiz.Operators.ValidLogicalOperators rule
@novikor novikor reopened this Mar 1, 2019
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Mar 1, 2019

Hi @orlangur, thank you for the review.
ENGCOM-4415 has been created to process this Pull Request

@sdzhepa sdzhepa moved this from Ready for Testing to Extended Testing (optional) in Pull Requests Dashboard Mar 21, 2019
@nmalevanec nmalevanec self-assigned this Mar 22, 2019
@nmalevanec nmalevanec moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Mar 22, 2019
@magento-engcom-team magento-engcom-team merged commit 9f0ef59 into magento:2.2-develop Mar 24, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

contribution-survey bot commented Mar 24, 2019

Hi @novikor, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@pull-request-dashboard-manager pull-request-dashboard-manager bot moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Mar 24, 2019
magento-engcom-team pushed a commit that referenced this pull request Mar 24, 2019
@magento-engcom-team magento-engcom-team added this to Ready to Port in Ports Wanted Mar 24, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Mar 24, 2019
@sidolov sidolov removed this from Ready to Port in Ports Wanted Mar 24, 2019
@sidolov sidolov removed this from Recently Merged in Pull Requests Dashboard May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.