Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Update price-bundle.js so that correct tier price is calculated while displaying in bundle product #21844

Conversation

@amol2jcommerce
Copy link
Contributor

amol2jcommerce commented Mar 20, 2019

Original Pull Request

#21469

Description (*)

By default tier price is sorted by "price_id". With this tier price calculation while displaying in bundle product is wrong. Need to sort tier price by "price_qty".

Fixed Issues (if relevant)

  1. #21467: Tier price of simple item not working in Bundle product

Manual testing scenarios (*)

  1. Create tier price as per described in above issue

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
By default tier price is sorted by "price_id". With this tier price calculation while displaying in bundle product is wrong. Need to sort tier price by "price_qty".
Issue created: #21467
By default tier price is sorted by "price_id". With this tier price calculation while displaying in bundle product is wrong. Need to sort tier price by "price_qty".
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Mar 20, 2019

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch

This comment has been minimized.

Copy link
Contributor

dmytro-ch commented Mar 22, 2019

@magento-engcom-team give me test instance

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Mar 22, 2019

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Mar 22, 2019

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21844.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@pull-request-dashboard-manager pull-request-dashboard-manager bot moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Mar 22, 2019
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Mar 22, 2019

Hi @dmytro-ch, thank you for the review.
ENGCOM-4557 has been created to process this Pull Request

@stoleksiy stoleksiy moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Mar 22, 2019
@stoleksiy stoleksiy self-assigned this Mar 22, 2019
@stoleksiy

This comment has been minimized.

Copy link

stoleksiy commented Mar 25, 2019

✔️ QA Passed

Result:

after

@stoleksiy stoleksiy moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Mar 25, 2019
@nmalevanec nmalevanec self-assigned this Mar 25, 2019
@nmalevanec nmalevanec moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Mar 25, 2019
@magento-engcom-team magento-engcom-team merged commit a14c804 into magento:2.2-develop Mar 26, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

contribution-survey bot commented Mar 26, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 26, 2019
…rice is calculated while displaying in bundle product #21844
@pull-request-dashboard-manager pull-request-dashboard-manager bot moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Mar 26, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Mar 26, 2019
@sidolov sidolov removed this from Recently Merged in Pull Requests Dashboard May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.