Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundant Gallery subscription for catalog rules #22320

Conversation

VitaliyBoyko
Copy link
Contributor

@VitaliyBoyko VitaliyBoyko commented Apr 13, 2019

Description (*)

Hi @magento-engcom-team

I suggest removing 'catalog_product_entity_gallery' subscription table which is not related to price/price-rules from CatalogRule mview.
Listening 'catalog_product_entity_gallery' causing a huge amount of records to changelog when saving the product with applied price rule in case the product has many product images.
Gallery attribute does not contain data related to pricing framework and can't be utilized creating price rule condition, so, I don't see a reason to listen to that table for the partial reindex changelog.

Thank you!

Manual testing scenarios (*)

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 13, 2019

Hi @VitaliyBoyko. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: CatalogRule Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Apr 13, 2019
@VitaliyBoyko VitaliyBoyko changed the title Vitalii Boiko: removed redundant subscriptions for catalog rules Removed redundant subscriptions for catalog rules Apr 13, 2019
@VitaliyBoyko VitaliyBoyko changed the title Removed redundant subscriptions for catalog rules Removed redundant Gallery subscription for catalog rules Apr 13, 2019
@dmytro-ch dmytro-ch self-requested a review April 14, 2019 15:18
@dmytro-ch dmytro-ch self-assigned this Apr 14, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4755 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4755 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 20, 2019

Hi @VitaliyBoyko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CatalogRule Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants