Fixed wrong url redirect when edit product review from Customer view page #22426

ravi-chandra3197 · 2019-04-19T10:03:52Z

Fixed wrong URL redirect when edit product review from the Customer view page
Fixed wrong URL redirect when edit product review from the view product page

Description (*)

Fixed Issues (if relevant)

wrong url redirect when edit product review from Customer view page #22425: wrong url redirect when edit product review from Customer view page

Manual testing scenarios (*)

Navigate to Customer for edit
CUSTOMER INFORMATION tab -> Product Reviews -> Edit Review
After edit review -> click on save
Catalog-> product-> Product Reviews
edit any review -> click on save

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

m2-assistant · 2019-04-19T10:03:54Z

Hi @ravi-chandra3197. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

orlangur · 2019-04-19T10:12:12Z

app/code/Magento/Review/Block/Adminhtml/Edit/Form.php

@@ -85,7 +85,8 @@ protected function _prepareForm()
                        [
                            'id' => $this->getRequest()->getParam('id'),
                            'ret' => $this->_coreRegistry->registry('ret'),
-                            'productId' => $this->getRequest()->getParam('productId')
+                            'productId' => $this->getRequest()->getParam('productId'),
+                            'customerId' => $this->getRequest()->getParam('customerId')


In case of edit from customer page productId will be empty?

Hello @orlangur
I have checked this in case of edit from customer page productId is not require because review edit using review id, productId, and customerId is additional param
here I have attached snapshot of edit form action which clearly show productId is not set so it will not be passed in action URL param.

https://prnt.sc/ne3if0

@ravi-chandra3197 I mean, there is no need to add productId / customerId when it is empty. Please refactor and squash changes.

@ravi-chandra3197 why did you mark conversation as resolved?

'productId' => $this->getRequest()->getParam('productId'),

here we should not add productId when it is empty. Same for customerId.

Hello @orlangur
I have update PR code as per your suggestion now we also check param before adding array can you review it.

orlangur · 2019-04-24T09:44:58Z

app/code/Magento/Review/Block/Adminhtml/Edit/Form.php

@@ -85,7 +85,8 @@ protected function _prepareForm()
                        [
                            'id' => $this->getRequest()->getParam('id'),
                            'ret' => $this->_coreRegistry->registry('ret'),
-                            'productId' => $this->getRequest()->getParam('productId')
+                            'productId' => $this->getRequest()->getParam('productId'),
+                            'customerId' => $this->getRequest()->getParam('customerId')


@ravi-chandra3197 I mean, there is no need to add productId / customerId when it is empty. Please refactor and squash changes.

ravi-chandra3197 · 2019-04-24T10:04:37Z

Hello @orlangur
I have check form post URL with 3 possible way edit review

edit review from review grid
https://prnt.sc/ng6d04
edit review from the view product page
https://prnt.sc/ng6c7q
edit review from the veiw customer page
https://prnt.sc/ne3if0

if productId / customerId empty then not added.

orlangur · 2019-04-24T12:11:32Z

app/code/Magento/Review/Block/Adminhtml/Edit/Form.php

@@ -85,7 +85,8 @@ protected function _prepareForm()
                        [
                            'id' => $this->getRequest()->getParam('id'),
                            'ret' => $this->_coreRegistry->registry('ret'),
-                            'productId' => $this->getRequest()->getParam('productId')
+                            'productId' => $this->getRequest()->getParam('productId'),
+                            'customerId' => $this->getRequest()->getParam('customerId')


@ravi-chandra3197 why did you mark conversation as resolved?

'productId' => $this->getRequest()->getParam('productId'),

here we should not add productId when it is empty. Same for customerId.

ravi-chandra3197 · 2019-04-24T12:30:40Z

Hello @orlangur
I have check form post URL with 3 possible way edit review

edit review from review grid
https://prnt.sc/ng6d04

edit review from the view product page
https://prnt.sc/ng6c7q

edit review from the veiw customer page
https://prnt.sc/ne3if0

if productId / customerId empty then not added.

Hello @orlangur
I have checked this if empty productId / customerId so it will not be added in URL which shows in above snapshot

orlangur · 2019-04-24T12:49:43Z

@ravi-chandra3197 they must not be added to array in the first place.

ravi-chandra3197 · 2019-04-24T13:39:34Z

Hello @orlangur
I have check form post URL with 3 possible way edit review
I have use print_r($form->getData()); and get following output

edit review from review grid
Array ( [id] => edit_form [action] => http://10.16.16.55/magento227/admin/review/product/save/id/374/key/6ea4cd512d29e609f66278ee7655f1da7562f8866296f20f0e0ec25fb5e43b90/ [method] => post )

https://prnt.sc/ng6d04

edit review from the view product page
Array ( [id] => edit_form [action] => http://10.16.16.55/magento227/admin/review/product/save/id/1/productId/1/key/6ea4cd512d29e609f66278ee7655f1da7562f8866296f20f0e0ec25fb5e43b90/ [method] => post )

https://prnt.sc/ng6c7q

edit review from the veiw customer page
Array ( [id] => edit_form [action] => http://10.16.16.55/magento227/admin/review/product/save/id/374/customerId/2/key/6ea4cd512d29e609f66278ee7655f1da7562f8866296f20f0e0ec25fb5e43b90/ [method] => post )

https://prnt.sc/ne3if0

if productId / customerId empty then not added.

orlangur · 2019-04-24T13:45:45Z

app/code/Magento/Review/Block/Adminhtml/Edit/Form.php

@@ -85,7 +85,8 @@ protected function _prepareForm()
                        [
                            'id' => $this->getRequest()->getParam('id'),
                            'ret' => $this->_coreRegistry->registry('ret'),
-                            'productId' => $this->getRequest()->getParam('productId')
+                            'productId' => $this->getRequest()->getParam('productId'),
+                            'customerId' => $this->getRequest()->getParam('customerId')


@ravi-chandra3197 here data must not be added to array when it is empty (current code produces lines like 'productId' => null).

ravi-chandra3197 · 2019-04-26T04:32:40Z

Hello @orlangur
I have update PR code as per your suggestion now we also check param before adding array can you review it.

orlangur

After changes are applied and all builds are green, please squash them into a single commit so that we have perfectly clean history 😉

orlangur · 2019-04-26T15:01:08Z

app/code/Magento/Review/Block/Adminhtml/Edit/Form.php

@@ -75,18 +75,23 @@ protected function _prepareForm()
        $review = $this->_coreRegistry->registry('review_data');
        $product = $this->_productFactory->create()->load($review->getEntityPkValue());

+        $formActionParam['id'] = $this->getRequest()->getParam('id');


formActionParams and please do initial assignment like $var = ['id' => ..., 'ret' => ...]

Hello @orlangur
I have change formActionParams and add initial assignment

orlangur · 2019-04-26T15:01:26Z

app/code/Magento/Review/Block/Adminhtml/Edit/Form.php

@@ -75,18 +75,23 @@ protected function _prepareForm()
        $review = $this->_coreRegistry->registry('review_data');
        $product = $this->_productFactory->create()->load($review->getEntityPkValue());

+        $formActionParam['id'] = $this->getRequest()->getParam('id');
+        $formActionParam['ret'] = $this->_coreRegistry->registry('ret');
+        if ($this->getRequest()->getParam('productId') != null) {


Suggested change

if ($this->getRequest()->getParam('productId') != null) {

if ($this->getRequest()->getParam('productId')) {

Same for customerId

Hello @orlangur
I have updated PR as your suggestion can you review it.

orlangur · 2019-04-29T08:42:43Z

app/code/Magento/Review/Block/Adminhtml/Edit/Form.php

@@ -75,18 +75,24 @@ protected function _prepareForm()
        $review = $this->_coreRegistry->registry('review_data');
        $product = $this->_productFactory->create()->load($review->getEntityPkValue());

+        $formActionParams =['id' => $this->getRequest()->getParam('id'),


@ravi-chandra3197 does this formatting looks good to you?

Hello @orlangur
I have updated PR.

orlangur

Please squash changes into a single commit so that we have perfectly clean history 😉

…page and edit product page

ravi-chandra3197 · 2019-05-01T04:07:26Z

Please squash changes into a single commit so that we have perfectly clean history

Hello @orlangur
I have squash changes into a single commit, can you review it.

magento-engcom-team · 2019-05-31T16:37:38Z

Hi @sidolov, thank you for the review.
ENGCOM-5195 has been created to process this Pull Request

VasylShvorak · 2019-06-04T07:19:15Z

Hi @ravi-chandra3197 I cannot reproduce issue "wrong URL redirect when edit product review from the view product page". Part of code in Save.php is not needed because of after edit and save review from product edit page we are redirected to product edit page as expected

ravi-chandra3197 · 2019-06-04T07:27:23Z

Hi @ravi-chandra3197 I cannot reproduce issue "wrong URL redirect when edit product review from the view product page". Part of code in Save.php is not needed because of after edit and save review from product edit page we are redirected to product edit page as expected

Hello @VasylShvorak
In my Previous PR #22202 , fix the issue for the wrong redirect after edit review from the view product page in this PR I have change for customer and update formActionParams which is used for both customer and product as well.

VasylShvorak · 2019-06-04T08:02:25Z

@ravi-chandra3197 I double check it again. Code from Save.php is used when edit review from customer edit page. Thanks

VasylShvorak · 2019-06-04T08:02:51Z

✔️ QA passed

magento-engcom-team · 2019-06-04T11:57:43Z

Hi @orlangur, thank you for the review.
ENGCOM-5195 has been created to process this Pull Request

…ustomer view page magento#22426

m2-assistant · 2019-06-07T03:10:11Z

Hi @ravi-chandra3197, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team added Component: Review Release Line: 2.3 Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Apr 19, 2019

rogyar self-assigned this Apr 19, 2019

orlangur requested changes Apr 19, 2019

View reviewed changes

ghost assigned orlangur Apr 19, 2019

ghost added the Progress: needs update label Apr 19, 2019

ravi-chandra3197 mentioned this pull request Apr 19, 2019

[Backport] Fixed wrong url redirect when edit product review from Customer view page and product view page #22430

Merged

4 tasks

orlangur requested changes Apr 24, 2019

View reviewed changes

orlangur requested changes Apr 26, 2019

View reviewed changes

ravi-chandra3197 force-pushed the patch-product-review-customer-redirect branch from 5b89e92 to e7034d3 Compare April 29, 2019 04:30

orlangur requested changes Apr 29, 2019

View reviewed changes

orlangur requested changes Apr 30, 2019

View reviewed changes

Fixed wrong URL redirect when edit product review from Customer view …

19e7380

…page and edit product page

ravi-chandra3197 force-pushed the patch-product-review-customer-redirect branch from 871e351 to 19e7380 Compare May 1, 2019 04:03

sidolov approved these changes May 31, 2019

View reviewed changes

ghost assigned sidolov May 31, 2019

ghost added Progress: ready for testing and removed Progress: needs update labels May 31, 2019

VasylShvorak self-assigned this Jun 3, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Jun 3, 2019

ghost added Progress: needs update and removed Progress: testing in progress labels Jun 4, 2019

ghost added Progress: testing in progress and removed Progress: needs update labels Jun 4, 2019

ghost added Progress: extended testing and removed Progress: testing in progress labels Jun 4, 2019

p-bystritsky self-assigned this Jun 4, 2019

orlangur approved these changes Jun 4, 2019

View reviewed changes

ghost added Progress: accept and removed Progress: extended testing labels Jun 4, 2019

magento-engcom-team mentioned this pull request Jun 7, 2019

wrong url redirect when edit product review from Customer view page #22425

Closed

magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request Jun 7, 2019

ENGCOM-5195: Fixed wrong url redirect when edit product review from C…

4c394a9

…ustomer view page magento#22426

magento-engcom-team merged commit 19e7380 into magento:2.3-develop Jun 7, 2019

magento-engcom-team added this to the Release: 2.3.3 milestone Jun 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed wrong url redirect when edit product review from Customer view page #22426

Fixed wrong url redirect when edit product review from Customer view page #22426

ravi-chandra3197 commented Apr 19, 2019 •

edited

m2-assistant bot commented Apr 19, 2019

orlangur Apr 19, 2019

ravi-chandra3197 Apr 19, 2019 •

edited

orlangur Apr 24, 2019

orlangur Apr 24, 2019

ravi-chandra3197 Apr 25, 2019

orlangur Apr 24, 2019

ravi-chandra3197 commented Apr 24, 2019

orlangur Apr 24, 2019

ravi-chandra3197 commented Apr 24, 2019 •

edited

orlangur commented Apr 24, 2019

ravi-chandra3197 commented Apr 24, 2019 •

edited

orlangur Apr 24, 2019

ravi-chandra3197 commented Apr 26, 2019

orlangur left a comment

orlangur Apr 26, 2019

ravi-chandra3197 Apr 29, 2019

orlangur Apr 26, 2019

ravi-chandra3197 Apr 29, 2019

orlangur Apr 29, 2019

ravi-chandra3197 Apr 29, 2019

orlangur left a comment

ravi-chandra3197 commented May 1, 2019

magento-engcom-team commented May 31, 2019

VasylShvorak commented Jun 4, 2019

ravi-chandra3197 commented Jun 4, 2019 •

edited

VasylShvorak commented Jun 4, 2019

VasylShvorak commented Jun 4, 2019

magento-engcom-team commented Jun 4, 2019

m2-assistant bot commented Jun 7, 2019

	if ($this->getRequest()->getParam('productId') != null) {
	if ($this->getRequest()->getParam('productId')) {

Fixed wrong url redirect when edit product review from Customer view page #22426

Fixed wrong url redirect when edit product review from Customer view page #22426

Conversation

ravi-chandra3197 commented Apr 19, 2019 • edited

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

m2-assistant bot commented Apr 19, 2019

Choose a reason for hiding this comment

ravi-chandra3197 Apr 19, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ravi-chandra3197 commented Apr 24, 2019

Choose a reason for hiding this comment

ravi-chandra3197 commented Apr 24, 2019 • edited

orlangur commented Apr 24, 2019

ravi-chandra3197 commented Apr 24, 2019 • edited

Choose a reason for hiding this comment

ravi-chandra3197 commented Apr 26, 2019

orlangur left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

orlangur left a comment

Choose a reason for hiding this comment

ravi-chandra3197 commented May 1, 2019

magento-engcom-team commented May 31, 2019

VasylShvorak commented Jun 4, 2019

ravi-chandra3197 commented Jun 4, 2019 • edited

VasylShvorak commented Jun 4, 2019

VasylShvorak commented Jun 4, 2019

magento-engcom-team commented Jun 4, 2019

m2-assistant bot commented Jun 7, 2019

ravi-chandra3197 commented Apr 19, 2019 •

edited

ravi-chandra3197 Apr 19, 2019 •

edited

ravi-chandra3197 commented Apr 24, 2019 •

edited

ravi-chandra3197 commented Apr 24, 2019 •

edited

ravi-chandra3197 commented Jun 4, 2019 •

edited