Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bakport] Adding product from wishlist not adding to cart showing warning message. #22536

Merged

Conversation

@niravkrish
Copy link
Contributor

niravkrish commented Apr 29, 2019

Original Pull Request

#19653

Description (*)

Adding product from wishlist not adding to cart showing warning message.

Fixed Issues (if relevant)

  1. #9155: Adding product from wishlist not adding to cart showing warning message.

Manual testing scenarios (*)

  1. Add a simple product from admin with Minimum Qty Allowed in Shopping Cart 10
  2. Login in front end
  3. Add product to wishlist
  4. Click on wishlist.
  5. Now showing allow qty as default in qty field.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
@m2-assistant

This comment has been minimized.

Copy link

m2-assistant bot commented Apr 29, 2019

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch

This comment has been minimized.

Copy link
Contributor

dmytro-ch commented Apr 29, 2019

@magento-engcom-team give me test instance

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Apr 29, 2019

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Apr 29, 2019

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-22536.instances.magento-community.engineering/admin
Login: admin Password: 123123q

Copy link
Contributor

dmytro-ch left a comment

Hi @niravkrish,
the current solution does not seem to be working.
The \Magento\Wishlist\Block\Customer\Wishlist\Item\Column\Cart cannot be instantiated due to the redundant constructor params, and namely \Magento\Catalog\Model\Product\Image\UrlBuilder which is not available in Magento 2.2.x version.
Please make sure the changes are working and compatible with Magento 2.2.x before creating a PR.

@pull-request-dashboard-manager pull-request-dashboard-manager bot moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Apr 29, 2019
@niravkrish niravkrish requested a review from dmytro-ch Apr 29, 2019
Copy link
Contributor

dmytro-ch left a comment

@niravkrish, could you please squash all commits into a single commit after applying the changes in order to clean up history?
Thank you!

@niravkrish niravkrish force-pushed the niravkrish:back-port-pull-19653 branch from a77ec3b to 4b3df81 Apr 30, 2019
@niravkrish niravkrish force-pushed the niravkrish:back-port-pull-19653 branch from 9446860 to c62ab93 Apr 30, 2019
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Apr 30, 2019

Hi @dmytro-ch, thank you for the review.
ENGCOM-4859 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this May 2, 2019
@VasylShvorak VasylShvorak moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard May 2, 2019
@nmalevanec nmalevanec self-assigned this May 2, 2019
@VasylShvorak

This comment has been minimized.

Copy link
Contributor

VasylShvorak commented May 2, 2019

✔️ QA passed

@VasylShvorak VasylShvorak moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard May 2, 2019
@nmalevanec nmalevanec moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard May 2, 2019
@magento-engcom-team magento-engcom-team merged commit 4402714 into magento:2.2-develop May 3, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@m2-assistant

This comment has been minimized.

Copy link

m2-assistant bot commented May 3, 2019

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@pull-request-dashboard-manager pull-request-dashboard-manager bot moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard May 3, 2019
magento-engcom-team pushed a commit that referenced this pull request May 3, 2019
…t showing warning message. #22536
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone May 3, 2019
@Rrego6

This comment has been minimized.

Copy link
Contributor

Rrego6 commented May 10, 2019

Hi @niravkrish . Thank you for your contribution. Unfortunately, we needed to revert this fix for the 2.2.9 release, as it includes BIC into a patch release.

@sidolov sidolov removed this from Recently Merged in Pull Requests Dashboard May 31, 2019
magento-team pushed a commit that referenced this pull request Jun 25, 2019
…adding to cart showing warning message. #22536

- This reverts commit c62ab93.
magento-team pushed a commit that referenced this pull request Jun 25, 2019
- reverting #22536, because of Backward Incompatible changes in the patch release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.