Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Travis builds - 2.3-develop #22798

Merged

Conversation

okorshenko
Copy link
Contributor

@okorshenko okorshenko commented May 8, 2019

Description (*)

Disabled Travis builds for magento2

  • travis build is not required on magento2 repository due to low test coverage and capacity
  • all required builds are implemented as GitHub checks

Read more about Magento Automated Testing

Fixed Issues (if relevant)

  1. no issues, just improvement

Manual testing scenarios (*)

  1. Travis build should not be triggering on PR creation/update

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

 - travis build is not required on magento2 repository
 - all required builds are implemented as GitHub checks
@m2-assistant
Copy link

m2-assistant bot commented May 8, 2019

Hi @okorshenko. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

 - updated Pull Request teample. Travis is not required
@okorshenko okorshenko changed the title Disable Travis builds Disable Travis builds - 2.3-develop May 8, 2019
@ghost ghost assigned slavvka May 8, 2019
@magento-engcom-team
Copy link
Contributor

Hi @slavvka, thank you for the review.
ENGCOM-5094 has been created to process this Pull Request

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have build status icon to Travis in readme file. Could you remove it?

@okorshenko
Copy link
Contributor Author

Hi @ihor-sviziev
Readme file is updated

@m2-assistant
Copy link

m2-assistant bot commented May 10, 2019

Hi @okorshenko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants