Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update app/code/core/Mage/Checkout/controllers/CartController.php (fix issue #27632) #232

wants to merge 1 commit into


None yet
2 participants

hectorj commented Feb 19, 2013

Apply trim() on posted coupon code, to fix http://www.magentocommerce.com/bug-tracking/issue?issue=13546


verklov commented Nov 7, 2013

Hello hectorj,
Sorry for the delay with the response.
Thank you for your contribution! Our team will review your pull request and respond as soon as our analysis is complete.

magento-team added a commit that referenced this pull request Nov 22, 2013
* Moved general action-related functionality to \Magento\App\Action\Action in the library. Removed Magento\Core\Controller\Varien\Action and related logic from the Magento_Core module
* Moved view-related methods from action interface to \Magento\App\ViewInterface with corresponding implementation
* Moved redirect creation logic from the action interface to \Magento\App\Response\RedirectInterface
* Moved Magento\Core common blocks to the library
* Added reading of etc/integration/config.xml and etc/integration/api.xml files for API Integrations
* Various improvements:
  * Email-related logic from the Core and Adminhtml modules consolidated in the new Email module
* GitHub requests:
  * [#238](#238) -- Improve escaping HTML entities in URL
  * [#199](#199) -- Replaced function calls to array_push with adding the elements directly
  * [#182](#182) -- By default use collection _idFieldName for toOption* methods.
  * [#233](#233) -- Google Rich Snippet Code
  * [#339](#339) -- Correcting 'cahce' typo in documentation.
  * [#232](#232) -- Update app/code/core/Mage/Checkout/controllers/CartController.php (fix issue #27632)
* Fixed bugs:
  * Fixed JavaScript error when printing orders from the frontend
  * Fixed Captcha problems on various forms when Captcha is enabled on the frontend
  * Fixed "Page not found" on category page if setting "Add Store Code to Urls" to "Yes" in the backend config
  * Fixed Fatal error when creating shipping label for returns

verklov commented Nov 25, 2013

Hello hectorj,
We have processed your pull request. The code should be available in version dev53 released last Friday.

Thank you for your contribution!

@verklov verklov closed this Nov 25, 2013

joanhe pushed a commit that referenced this pull request Dec 9, 2015

mmansoorebay pushed a commit that referenced this pull request Aug 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment