Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] issue #22676 fixed - Compare Products counter, and My Wish List count… #23573

Conversation

@krishprakash
Copy link

krishprakash commented Jul 5, 2019

Original Pull Request

#22742

Description (*)

I have added vertical-align:middle; to align the Compare Products counter, and My Wish List counter in the sidebar.

Fixed Issues (if relevant)

  1. #22676: Compare Products counter, and My Wish List counter vertical not aligned

Manual testing scenarios (*)

  1. Added Products to Wishlist and Compare
  2. Opened Customer Account section to check the alignment in the sidebar

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
@m2-assistant

This comment has been minimized.

Copy link

m2-assistant bot commented Jul 5, 2019

Hi @krishprakash. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@krishprakash

This comment has been minimized.

Copy link
Author

krishprakash commented Jul 5, 2019

@magento give me test instance

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Jul 5, 2019

Hi @krishprakash. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Jul 5, 2019

Hi @krishprakash, here is your new Magento instance.
Admin access: https://pr-23573.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@krishprakash

This comment has been minimized.

Copy link
Author

krishprakash commented Jul 5, 2019

Fixed in given instance.

@rogyar rogyar self-assigned this Jul 5, 2019
@pull-request-dashboard-manager pull-request-dashboard-manager bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard Jul 5, 2019
@rogyar
rogyar approved these changes Jul 5, 2019
@pull-request-dashboard-manager pull-request-dashboard-manager bot moved this from Review in Progress to Ready for Testing in Pull Requests Dashboard Jul 5, 2019
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

magento-engcom-team commented Jul 5, 2019

Hi @rogyar, thank you for the review.
ENGCOM-5399 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jul 5, 2019
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jul 5, 2019
@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Jul 5, 2019
@engcom-Alfa

This comment has been minimized.

Copy link

engcom-Alfa commented Jul 5, 2019

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Jul 5, 2019
@magento-engcom-team magento-engcom-team merged commit 2a05255 into magento:2.2-develop Jul 5, 2019
10 checks passed
10 checks passed
Database Compare build Build reports
Details
Functional Tests build Build reports
Details
Integration Tests build Build reports
Details
Magento Health Index build Build reports
Details
Sample Data Tests build Build reports
Details
Semantic Version Checker build Build reports
Details
Static Tests build Build reports
Details
Unit Tests build Build reports
Details
WebAPI Tests build Build reports
Details
licence/cla Contributor License Agreement is signed.
Details
@m2-assistant

This comment has been minimized.

Copy link

m2-assistant bot commented Jul 5, 2019

Hi @krishprakash, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@pull-request-dashboard-manager pull-request-dashboard-manager bot moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Jul 5, 2019
magento-engcom-team pushed a commit that referenced this pull request Jul 5, 2019
…, and My Wish List count… #23573
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone Jul 5, 2019
@magento-engcom-team magento-engcom-team removed this from Recently Merged in Pull Requests Dashboard Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.