Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve indexer.xml & mview.xml not allowing numbers in vendor and class name #24324

Merged
merged 2 commits into from Sep 4, 2019

Conversation

Jason-Sy
Copy link
Member

Description (*)

Fixed Issues (if relevant)

  1. indexer.xml & mview.xml doesn't allow numbers in vendor name and class name #24323: indexer.xml & mview.xml doesn't allow numbers in vendor name and class name

Manual testing scenarios (*)

  1. Create a simple module with a vendor name which contains at least one number (ex. Mage2Vendor)
  2. Add a custom indexer to the module just like on the devdocs
  3. setup:upgrade

Questions or comments

Is based of #8037 but added a \ check so it's still possible to start with .

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 27, 2019

Hi @Jason-Sy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 27, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-5724 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@Jason-Sy thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Sep 4, 2019

Hi @Jason-Sy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants