Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #24842: Unable to delete custom option file in admin order create #24843

Conversation

adrian-martinez-interactiv4
Copy link
Contributor

Fix inputBox selector to match html structure.

Description (*)

Fixed Issues (if relevant)

  1. Unable to delete custom option file in admin order create #24842: Unable to delete custom option file in admin order create

Manual testing scenarios (*)

  1. Follow Unable to delete custom option file in admin order create #24842 steps to reproduce, and for actual and expected results.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…er create

Fix inputBox selector to match html structure
@m2-assistant
Copy link

m2-assistant bot commented Oct 3, 2019

Hi @adrian-martinez-interactiv4. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Interactiv4 Pull Request is created by partner Interactiv4 partners-contribution Pull Request is created by Magento Partner labels Oct 3, 2019
@kalpmehta kalpmehta self-assigned this Oct 3, 2019
Copy link
Contributor

@sidolov sidolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrian-martinez-interactiv4 nice catch! Please, cover changes with the functional test to avoid such issues in the future. Thank you!

@ghost ghost assigned sidolov Oct 4, 2019
@adrian-martinez-interactiv4
Copy link
Contributor Author

I've been looking at mftf files and examples, and sincerely, I don't know how to replicate use case of upload a file (or having a file uploaded), to check then that file box name gets striked-through and file gets erased...

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:19
@lenaorobei
Copy link
Contributor

@engcom-Echo please help with MFTF tests here.

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6818 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Echo engcom-Echo self-assigned this Feb 7, 2020
… FR23#FEATURE-UNABLE-DELETE-CUSTOM-OPTION-FILE
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

No JS error appears in the console. The order item is updated and the order proceeds
delete_file

@engcom-Echo
Copy link
Contributor

I will take care of test coverage.

@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2020

Hi @adrian-martinez-interactiv4, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants