Skip to content

Conversation

srsathish92
Copy link
Contributor

@srsathish92 srsathish92 commented Dec 15, 2019

Description (*)

[Contact] covered Model Config by Unit Test
Path: app/code/Magento/Contact/Model/Config.php

Manual testing scenarios (*)

vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist app/code/Magento/Contact/Test/Unit/Model/ConfigTest.php

Questions or comments

If any please let me know your feedback

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 15, 2019

Hi @srsathish92. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Dec 15, 2019
@dmytro-ch dmytro-ch self-assigned this Dec 16, 2019
@dmytro-ch
Copy link
Contributor

@srsathish92, thank you for the updates.

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6484 has been created to process this Pull Request
✳️ @dmytro-ch, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Charlie
Copy link
Contributor

✔️ QA Passed

@magento-engcom-team magento-engcom-team merged commit b394255 into magento:2.4-develop Dec 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 18, 2019

Hi @srsathish92, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants