Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Fix for - 26181 #26183

Conversation

divyajyothi5321
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Out of stock text is not aligned properly with add to cart button at list page in responsive  #26181: Out of stock text is not aligned properly with add to cart button at list page in responsive

Manual testing scenarios (*)

  1. Go to Frond end and product listing page
  2. With this fix in mobile view the out of stock text and add links are aligned compared with add to cart button as shown below

outofstok-expected

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 26, 2019

Hi @divyajyothi5321. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@rogyar
Copy link
Contributor

rogyar commented Dec 28, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-26183.instances.magento-community.engineering/admin
Login: admin Password: 123123q

Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @divyajyothi5321. Thank you for your collaboration.

At some resolutions, they are still not aligned (check the wishlist and compare icons).
image

Also, I'm not sure that an additional color (orange) should be used in this particular case. The alignment fix is required, no doubts here. But bringing additional colors to the theme might be a topic for additional debates.

@ghost ghost assigned rogyar Dec 28, 2019
@divyajyothi5321
Copy link
Contributor Author

@rogyar Can we add custom breakpoints in theme

@divyajyothi5321
Copy link
Contributor Author

For integration test I'm getting "testTableSelection with data set #1" from the source "Magento\Reports\Model\ResourceModel\Report\Product\Viewed\CollectionTest.testTableSelection with data set #16", which is not related to any CSS changes made by me.

@rogyar
Copy link
Contributor

rogyar commented Jan 2, 2020

Hi @divyajyothi5321. The tests are slightly broken. We are waiting for PR with the fixes for tests to be merged soon.
As for the custom media queries, it depends. But I would say that we may not introduce custom media queries in most cases since such change might be considered as backward incompatible.

@divyajyothi5321
Copy link
Contributor Author

@rogyar thank you for your suggestion, I didn't add any custom media queries adjusted with existing media queries and now all checks are passed please review my latest changes and let me know for any modifications.

@rogyar
Copy link
Contributor

rogyar commented Jan 3, 2020

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-26183.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jan 3, 2020
@rogyar
Copy link
Contributor

rogyar commented Jan 3, 2020

Hi @divyajyothi5321. Now it's much better. Thank you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-6536 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Jan 8, 2020

Hi @divyajyothi5321, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: i95Dev partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants