Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Wishlist] Fixing the default value when wishlist item quantity isn't defined #29904

Merged

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Sep 4, 2020

Description (*)

This PR is a follow up of the magento/partners-magento2ee/pull/248, where the quantity may not be passed as an input argument.

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. Try adding a product to Wish list without specifying the quantity argument.
  2. No error should be thrown

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 4, 2020

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Sep 4, 2020
@magento-engcom-team magento-engcom-team added Component: Wishlist Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Sep 4, 2020
@lenaorobei lenaorobei self-assigned this Sep 4, 2020
@lenaorobei
Copy link
Contributor

Hi @eduard13. Should this PR be delivered with magento/partners-magento2ee#248?

@eduard13
Copy link
Contributor Author

eduard13 commented Sep 4, 2020

Hi @lenaorobei, there is no strict requirement, we can deliver it even before if possible.

@lenaorobei
Copy link
Contributor

I see that WebAPI Tests are failing and it is definitely related to this change.
Please add ee PR as related if needed (Related Pull requests section of description).

@eduard13
Copy link
Contributor Author

eduard13 commented Sep 4, 2020

@lenaorobei the failed WebAPI test is related directly to the ee PR (as I triggered these tests from there). I may run the tests without the related PR, to have all the builds green.

@BarnyShergold BarnyShergold self-assigned this Sep 6, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Sep 6, 2020
@magento-engcom-team
Copy link
Contributor

Hi @BarnyShergold, thank you for the review.
ENGCOM-8148 has been created to process this Pull Request
✳️ @BarnyShergold, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@BarnyShergold
Copy link

Auto-Tests: Covered

@rogyar rogyar added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Sep 8, 2020
@eduard13 eduard13 added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 8, 2020
@ghost ghost moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 10, 2020
@ghost ghost moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Sep 11, 2020
@magento-engcom-team magento-engcom-team merged commit 6ffc556 into magento:2.4-develop Sep 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 13, 2020

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Wishlist Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Project: GraphQL Release Line: 2.4
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

None yet

6 participants