Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFTF: Replace repetitive actions with Action Groups in AdminUpdateCategoryAndMakeInactiveTest and VerifyChildCategoriesShouldNotIncludeInMenuTest #30049

Merged
merged 11 commits into from Sep 30, 2020
Merged

MFTF: Replace repetitive actions with Action Groups in AdminUpdateCategoryAndMakeInactiveTest and VerifyChildCategoriesShouldNotIncludeInMenuTest #30049

merged 11 commits into from Sep 30, 2020

Conversation

kate-kyzyma
Copy link
Contributor

@kate-kyzyma kate-kyzyma commented Sep 15, 2020 •
edited by m2-assistant bot

Description (*)

AdminUpdateCategoryAndMakeInactiveTest and VerifyChildCategoriesShouldNotIncludeInMenuTest are refactored according to the best practices followed by MFTF.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

AdminUpdateCategoryAndMakeInactiveTest and VerifyChildCategoriesShouldNotIncludeInMenuTest in the local environment and verified the tests run successfully.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] MFTF: Replace repetitive actions with Action Groups in AdminUpdateCategoryAndMakeInactiveTest and VerifyChildCategoriesShouldNotIncludeInMenuTest #30058: MFTF: Replace repetitive actions with Action Groups in AdminUpdateCategoryAndMakeInactiveTest and VerifyChildCategoriesShouldNotIncludeInMenuTest

@m2-assistant
Copy link

m2-assistant bot commented Sep 15, 2020

Hi @kate-kyzyma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Sep 15, 2020
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Sep 15, 2020
@dmytro-ch dmytro-ch self-assigned this Sep 15, 2020
@magento magento deleted a comment from magento-engcom-team Sep 15, 2020
@magento-engcom-team
Copy link
Contributor

Pull request successfully imported into magento-engcom/magento2ce repository. Branch name: imported-magento-magento2-30049.

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 15, 2020
@sidolov
Copy link
Contributor

sidolov commented Sep 15, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Sep 15, 2020
Closed
4 tasks
@dmytro-ch dmytro-ch added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 24, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Sep 24, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-8267 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Sep 24, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 24, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Sep 24, 2020
@engcom-Charlie engcom-Charlie self-assigned this Sep 24, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@sidolov sidolov moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Sep 25, 2020
magento-engcom-team pushed a commit that referenced this pull request Sep 30, 2020
@sidolov
ENGCOM-8267: MFTF: Replace repetitive actions with Action Groups in A…
2451f3f 
…dminUpdateCategoryAndMakeInactiveTest and VerifyChildCategoriesShouldNotIncludeInMenuTest #30049
@magento-engcom-team magento-engcom-team merged commit 4059224 into magento:2.4-develop Sep 30, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 30, 2020

Hi @kate-kyzyma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
6 participants
@kate-kyzyma @magento-engcom-team @sidolov @engcom-Alfa @engcom-Charlie @dmytro-ch