Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/partners-magento2b2b#312: Edit Account Information Page Shows… #30075

Conversation

garmashdev
Copy link
Contributor

@garmashdev garmashdev commented Sep 16, 2020

Edit Account Information Page Shows Editable Company & Job Title Field for B2B Users

  • added StorefrontVerifyCustomerAccountInformationActionGroup to customer module

Description (*)

Related Pull Requests

https://github.com/magento/partners-magento2b2b/pull/316

Fixed Issues (if relevant)

  1. Fixes Fix default Magento font in order PDF (and filesize of 1MB +) #312: Edit Account Information Page Shows Editable Company & Job Title Field for B2B Users

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

… Editable Company & Job Title Field for B2B Users

- added StorefrontVerifyCustomerAccountInformationActionGroup to customer module
@m2-assistant
Copy link

m2-assistant bot commented Sep 16, 2020

Hi @garmashdev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Sep 16, 2020
@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. project: B2B labels Sep 16, 2020
dhaecker
dhaecker previously approved these changes Sep 17, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Sep 17, 2020
@ghost ghost assigned dhaecker Sep 17, 2020
@ghost ghost moved this from Ready for Testing to Changes Requested in Pull Requests Dashboard Sep 18, 2020
@ghost ghost dismissed dhaecker’s stale review September 18, 2020 17:13

Pull Request state was updated. Re-review required.

danmooney2
danmooney2 previously approved these changes Sep 21, 2020
@ghost ghost moved this from Changes Requested to Ready for Testing in Pull Requests Dashboard Sep 21, 2020
@ghost ghost assigned danmooney2 Sep 21, 2020
@ghost ghost moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 21, 2020
@ghost ghost moved this from Testing in Progress to To Approve in Pull Requests Dashboard Sep 21, 2020
@ghost ghost dismissed danmooney2’s stale review September 21, 2020 16:34

Pull Request state was updated. Re-review required.

@ghost ghost moved this from To Approve to Ready for Testing in Pull Requests Dashboard Sep 21, 2020
@ghost ghost moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Sep 21, 2020
@ghost ghost moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Sep 21, 2020
@magento-engcom-team magento-engcom-team merged commit 36d1e99 into 2.4-develop Sep 28, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 28, 2020

Hi @garmashdev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 28, 2020
@okorshenko okorshenko deleted the 312_edit_account_information_page_shows_editable_company branch February 9, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Customer PAP B2B Team 1 Priority: P3 May be fixed according to the position in the backlog. Progress: accept project: B2B Release Line: 2.4 Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
  
Recently Merged
Development

Successfully merging this pull request may close these issues.

Fix default Magento font in order PDF (and filesize of 1MB +)
5 participants