ImportExport: Easier debugging #324

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

amenk commented Jul 24, 2013

Made the import more robust if import file links to a SKU which is skipped for some reasons -> leads to a "NULL" link causing fatal errors.

Steps to reproduce:

  • Import file with SKU "1" in first line, but some errors (i.e. missing description)
  • In second line SKU "2", valid product data, _links_upsell_sku contains the SKU "1"
@amenk amenk ImportExport: Easier debugging
Made the import more robust if import file links to a SKU which is skipped for some reasons -> leads to a "NULL" link causing fatal errors.

Steps to reproduce:

* Import file with SKU "1" in first line, but some errors (i.e. missing description)
* In second line SKU "2", valid product data, _links_upsell_sku contains the SKU "1"
03c137d
Contributor

verklov commented Nov 7, 2013

Hello amenk,
Sorry for the delay with the response.
Thank you for your contribution! Our team will review your pull request and respond as soon as our analysis is complete.

@magento-team magento-team added a commit that referenced this pull request Dec 19, 2013

@magento-team magento-team 2.0.0.0-dev57
* Fixed bugs:
  * Fixed [MAP]: "Click for price" link is broken on the category page
  * Fixed tax rule search on the grid
  * Fixed redirect on dashboard if "Search", "Reset", "Export" buttons are clicked on several pages
  * Fixed switching user to alternate store-view when clicking on the Category (with Add Store Code to Urls="Yes" in the config)
  * Fixed printing Order/Shipping/Credit Memo from backend
  * Fixed 404 Error on attempt to print Shipping Label
  * Fixed duplication of JavaScript Resources in head on frontend
  * Fixed inconsistency with disabled states on Configurable product page in the Plushe theme
  * Fixed 3D Secure Information absence on Admin Order Info page
  * Fixed possibility to download or revert Backup
  * Fixed session fixation in user registration during checkout
  * Fixed fatal error during login to backend
  * Fixed inline translations in the Adminhtml area
  * Fixed partial refunds/invoices in Payflow Pro
  * Fixed the issue with ignoring area in design emulation
  * Fixed order placing with virtual product using Express Checkout
  * Fixed the error during order placement with Recurring profile payment
  * Fixed wrong redirect after customer registration during multishipping checkout
  * Fixed inability to crate shipping labels
  * Fixed inability to switch language, if the default language is English
  * Fixed an issue with incorrect XML appearing in cache after some actions on the frontend
  * Fixed product export
  * Fixed inability to configure memcache as session save handler
* GitHub requests:
  * [#406](#406) -- Remove cast to (int) for the varch increment_id
  * [#425](#425) -- Installation of dev53 fails
  * [#324](#324) -- ImportExport: Easier debugging
* Modularity improvements:
  * Removed \Magento\App\Helper\HelperFactory
  * Removed the "helper" method from the abstract block interface
  * Layout page type config moved to library
  * Design loader moved to library
  * Theme label moved to library
  * Remaining part from Adminhtml moved to the appropriate modules. Adminhtml module has been eliminated
  * Core Session and Cookie models decomposed and moved to library
    * \Magento\Stdlib\Cookie library created
    * Session Manager and Session Config interfaces provided
    * Session save handler interface created
    * Session storage interface created, session does not extend \Magento\Object anymore
    * Session validator interface created
    * Session generic wrapper moved to library
    * Messages functionality moved from the Session model as separate component, message manager interface created
    * Sid resolver interface created to handle session sid from request
69663a1
Contributor

verklov commented Dec 20, 2013

amenk,
Our team has processed your pull request. The code has been released in version dev57. We will be waiting for your new contributions!

verklov closed this Dec 20, 2013

@magento-team magento-team pushed a commit that referenced this pull request May 29, 2015

@Pechenushko Pechenushko Merge pull request #324 from magento-mpi/MAGETWO-37735
[MPI] Magento Centinel Removal
4d42108

@magento-team magento-team pushed a commit that referenced this pull request Jan 21, 2016

@rganin rganin Merge pull request #324 from magento-troll/MAGETWO-48042
[Troll] Bugfixes
5d5738a

@mmansoorebay mmansoorebay pushed a commit that referenced this pull request Sep 5, 2016

@VladimirZaets VladimirZaets Merge pull request #324 from magento-folks/MAGETWO-57129
Bug
MAGETWO-56473 Can't run B2B functional tests for logic with asynchronous operations

Story
MAGETWO-57129 Optional RabbitMQ Component
5c6b2d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment