Incorrect http method issue fix

[Mohamed-Asar]

Description (*)

Incorrect http method class removed

Fixed Issues (if relevant)

1. Fixes 404 when exporting csv and excel in Ordered Products Report #39261

Manual testing scenarios (*)

1. Go to REPORTS > Products > Ordered
2. Select a date range for which the product was sold.
3. Click to Export csv or excel
4. Verify if the file is exported or not.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Mohamed-Asar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[Mohamed-Asar]

@magento run all tests

[Mohamed-Asar]

@magento run all tests

[ihor-sviziev]

Looks like this issue was already fixed in 7677eb6 (merged to 2.4-develop branch)

@Mohamed-Asar, could you please confirm that?

[Mohamed-Asar]

@ihor-sviziev Yes This issue was fixed by adobe team, I verified in my local instance with latest 2.4-develop branch

[hostep]

@ihor-sviziev: just a random remark, but I always learned that GET requests should only fetch data, never perform "actions". Some browsers sometimes pre-fetch GET requests without any user interaction, if a GET request actually triggers an action, unexpected things can happen without any interaction, which may be very bad.

So no idea if this fix here (or the one from Adobe), is actually a good idea ... As exports can now be triggered by a GET request?
Just my 2 cents.

[ihor-sviziev]

@hostep i fully agree with you, but it was like that for a long time. Unfortunately all actions are done with get method in Magento, that’s really stupid.
I would suggest reporting this issue separately, because it will require fixing many different places, both in JS and controllers

[ihor-sviziev]

Hi @Mohamed-Asar,
Thanks for confirming, so I’m closing this pull request now