New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Framework][Translate] Better translation loading order #4783

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
@ddattee

ddattee commented May 30, 2016

Translation files of theme should be loaded after translation pack to allow the theme to override the translation pack.

David Dattee
[Framework][Translate] Better translation loading order to allow them…
…e translation to override language pack
@PascalBrouwers

This comment has been minimized.

Contributor

PascalBrouwers commented Aug 18, 2016

@victorgugo can you merge this?

@jalogut

This comment has been minimized.

Contributor

jalogut commented Sep 19, 2016

Hello, I have the same problem. Could you please merge this?

@magento-cicd2

This comment has been minimized.

Contributor

magento-cicd2 commented Dec 20, 2016

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


David Dattee seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@ddattee ddattee force-pushed the ddattee:develop branch from 4b5c1e1 to b5db3c7 Dec 20, 2016

@astorm

This comment has been minimized.

astorm commented Dec 30, 2016

@magento-cicd2 Any reason this isn't merged? It looks like @ddattee has a signed contributor agreement. /cc @piotrekkaminski

@danslo

This comment has been minimized.

Contributor

danslo commented Dec 31, 2016

@astorm There's also an updated PR with a signed CLA and where the tests got updated (#7142).

@schmengler

This comment has been minimized.

Contributor

schmengler commented Mar 21, 2017

Closed as duplicate of #7142

@schmengler schmengler closed this Mar 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment