Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Framework][Translate] Better translation loading order #4783

Closed
wants to merge 1 commit into from

Conversation

ddattee
Copy link

@ddattee ddattee commented May 30, 2016

Translation files of theme should be loaded after translation pack to allow the theme to override the translation pack.

@PascalBrouwers
Copy link
Contributor

@victorgugo can you merge this?

@jalogut
Copy link
Contributor

jalogut commented Sep 19, 2016

Hello, I have the same problem. Could you please merge this?

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 20, 2016

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


David Dattee seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@astorm
Copy link

astorm commented Dec 30, 2016

@magento-cicd2 Any reason this isn't merged? It looks like @ddattee has a signed contributor agreement. /cc @piotrekkaminski

@danslo
Copy link
Contributor

danslo commented Dec 31, 2016

@astorm There's also an updated PR with a signed CLA and where the tests got updated (#7142).

@schmengler
Copy link
Contributor

Closed as duplicate of #7142

@schmengler schmengler closed this Mar 21, 2017
magento-cicd2 pushed a commit that referenced this pull request Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet