Setup script: Remove config for specific scope ID #515

wants to merge 1 commit into


None yet

3 participants

amenk commented Feb 26, 2014

No description provided.

verklov commented Feb 28, 2014

@amenk, this method is not used within the code and we are considering removal of this method from the code base. Could you please provide us with use cases explaining the suggested change?

@verklov verklov added the major-check label Feb 28, 2014
@verklov verklov self-assigned this Feb 28, 2014

I think we should rename $scope_id to camel-case named variable, also it may be string.

@verklov verklov added major-ask and removed major-check labels Feb 28, 2014
verklov commented Apr 25, 2014

@amenk, sorry, we cannot accept your pull request. Here is the comment from the developer I got regarding this issue:

The $scope_id method has been removed as it is not used in our code. Third-party extensions may simply manipulate with core_config_data table. In general it's not a good practice to remove something added by other code.

We are closing this issue.

@verklov verklov closed this Apr 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment