New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Framework][Translate] Changed translation order to allow language #7142

Merged
merged 1 commit into from Mar 21, 2017

Conversation

@JSchlarb
Contributor

JSchlarb commented Oct 22, 2016

Pull request is already done by #4783 but he didn't update the test.

Issues: #6563, #6753

@magento-cicd2

This comment has been minimized.

Contributor

magento-cicd2 commented Oct 22, 2016

CLA assistant check
All committers have signed the CLA.

@PascalBrouwers

This comment has been minimized.

Contributor

PascalBrouwers commented Jan 12, 2017

@piotrekkaminski Care to take a look at this one and get it merged? This one is a bit better than #4783 I think.

@schmengler schmengler self-assigned this Mar 10, 2017

@schmengler schmengler added this to the March 2017 milestone Mar 10, 2017

@schmengler schmengler moved this from TODO to Review In Progress in Community Pull Requests Mar 10, 2017

@schmengler

This comment has been minimized.

Contributor

schmengler commented Mar 21, 2017

Thank you for your contribution, this is a very valuable PR! I confirmed with the Magento team that we can accept the change 👍

@schmengler schmengler moved this from Review In Progress to Merging In Progress in Community Pull Requests Mar 21, 2017

@magento-team magento-team merged commit 38d4e24 into magento:develop Mar 21, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@vrann

This comment has been minimized.

Contributor

vrann commented Mar 21, 2017

@JSchlarb PR is merged, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment