Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Zend feed refactoring #9347
Refactoring in order to move hardcoded Zend_Feed dependency into interface for further refactoring. Ticket #9240
I have created an interface that replaces Zend_Feed::importArray static call. The concrete class takes Zend_Feed object and returns it's own result that's a wrapper around Zend_Feed_Abstract.
I am not sure what the policies are on this type of things so I just went with the bare minimum of what is required.
Would appreciate hearing your thoughts on this one.
@ldusan84 @benmarks We are looking into this PR. Review takes somewhat more time then usual, since it introduces updates to the API, which must be in ideal desired-state if updated. We attempt to design APIs which would not require and additional changes in foreseeable future.
Thank you for your patience.
referenced this pull request
Feb 17, 2018
moved this from Review In Progress
to Testing In Progress
in Community Pull Requests
Apr 30, 2018
Please do not change or modify the code in your branch till merge.