Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Browser configurable with command line option #955

Closed
wants to merge 1 commit into from
Closed

Make Browser configurable with command line option #955

wants to merge 1 commit into from

Conversation

Vinai
Copy link
Contributor

@Vinai Vinai commented Jan 12, 2015

Move the check if the browser binary exists into the block with the default
discovery. This makes it possible to configure the Browser in the jsTestDriver.php
file with command line arguments.
For example:

    'Browser' => '/Applications/Firefox.app/Contents/MacOS/firefox -P "selenium"',

Without the change the check would fail, since the value is not an existing
file name, but rather a file name including command line options.

Move the check if the browser binary exists into the block with the default
discovery. This makes it possible to configure the Browser in the jsTestDriver.php
file with command line arguments.
For example:

'Browser' => '/Applications/Firefox.app/Contents/MacOS/firefox -P "selenium"',

Without the change the check would fail, since the value is not an existing
file name, but rather a file name including command line options.
@Vinai
Copy link
Contributor Author

Vinai commented Jan 12, 2015

Closed, a larger refactoring PR for the run_js_test.php script is coming.

@Vinai Vinai closed this Jan 12, 2015
@Vinai Vinai deleted the js-tests-browser-conf branch January 14, 2015 08:56
magento-team pushed a commit that referenced this pull request Mar 24, 2017
[EngCom] Fix relative template references in individual Magento modules #1895
magento-team pushed a commit that referenced this pull request Jan 19, 2018
 - Merge Pull Request magento-engcom/magento2ce#955 from RomaKis/magento2:8624
 - Merged commits:
   1. 15928fb
   2. 188ecb3
   3. 546a0bb
   4. 4b585d4
   5. a9a3c19
hostep pushed a commit to hostep/magento2 that referenced this pull request Aug 11, 2018
…-engcom/develop-prs-isolated

[EngCom] Fix relative template references in individual Magento modules magento#1895

(cherry picked from commit a434162)
magento-engcom-team added a commit that referenced this pull request Oct 2, 2019
 - Merge Pull Request magento/graphql-ce#955 from swnsma/graphql-ce:Add-Shipping-Address-Input-Extension
 - Merged commits:
   1. d42c828
   2. 0402368
   3. be027d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant