Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie Restriction Mode Overlay should not be cached by Varnish #6455 #9711

Merged
merged 1 commit into from May 24, 2017

Conversation

@bka
Copy link
Contributor

bka commented May 20, 2017

Description

Changed user-dependend isUserNotAllowSaveCookie condition in notice.ptml to fix varnish caching issue #6455

The proposed solution for this problem is that alertinfo container is always present in dom, no matter what cookie data the user has set, it should only depend on the setting if cookie restriction mode is enabled.

Fixed Issues (if relevant)

  1. #6455

Manual testing scenarios

Follow steps in issue #6455

…html to fix varnish caching issue #6455
@ishakhsuvarov ishakhsuvarov self-assigned this May 20, 2017
@ishakhsuvarov ishakhsuvarov added this to the May 2017 milestone May 20, 2017
@magento-team magento-team merged commit 058f287 into magento:develop May 24, 2017
3 checks passed
3 checks passed
codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@vrann

This comment has been minimized.

Copy link
Contributor

vrann commented May 24, 2017

@bka merged, thanks!

@magento-team

This comment has been minimized.

Copy link
Contributor

magento-team commented May 24, 2017

@bka thank you for your contribution. Your Pull Request has been successfully merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.