Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#issue-1108 Describe Image Detail for products #1110

Conversation

ZhovnirMaria
Copy link
Contributor

@ZhovnirMaria ZhovnirMaria commented Mar 25, 2021

Purpose of this pull request

This pull request describes the properties of the "Image Detail" window for customizing product images displaying.

Magento release version

  • 2.4.x

    Specify a patch release number, if applicable:

  • 2.3.x

    Specify a patch release number, if applicable:

Product editions

Is this update specific to a product edition?

  • Magento Open Source only
  • Magento Commerce only

Is this update specific to an installed feature extension

  • B2B extension
  • Other feature set, please specify:

Affected documentation pages

https://docs.magento.com/user-guide/catalog/product-images-and-video.html

Additional information

image

whatsnew
In Images and Video, added the Image Detail section to describe customizing product image display.

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Mar 25, 2021
@atwixfirster
Copy link
Contributor

Thank you for your contributions, @ZhovnirMaria

Your changes totally make sense.

Copy link
Contributor

@leslietilling leslietilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edits for style, grammer, and formatting


## Image Detail

When product images are added, there is the possibility to customize their displaying in the **Image Detail** window.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When product images are added, there is the possibility to customize their displaying in the **Image Detail** window.
When product images are added, there is the possibility to customize the display in the _Image Detail_ window.

![]({% link images/images/image-video.png %}){: .zoom}
_Product images_

Set image displaying options for a product:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Set image displaying options for a product:
To set image displaying options for a product:


Set image displaying options for a product:

1. Click on the product image.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Click on the product image.
1. Click the product image.

- **Small**
- **Thumbnail**

All of these roles are selected for the first added image by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
All of these roles are selected for the first added image by default.
All of these roles are selected for the first added image by default.


All of these roles are selected for the first added image by default.

![]({% link images/images/details.png %}){: .zoom}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![]({% link images/images/details.png %}){: .zoom}
![]({% link images/images/details.png %}){: .zoom}

![]({% link images/images/details.png %}){: .zoom}
_Image details_

To hide the product image from the product page select the **Hide from Product Page** checkbox.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To hide the product image from the product page select the **Hide from Product Page** checkbox.
To hide the product image from the product page, select the **Hide from Product Page** checkbox.

@m2-community-project m2-community-project bot moved this from Reviewer Approved to Review in Progress in Pull Request Progress Apr 5, 2021
@leslietilling leslietilling added Major update Significant new info: new section in existing topic, etc. 2.4.x Changes for the Core 2.4.x release line, not patch specific labels Apr 5, 2021
@ZhovnirMaria
Copy link
Contributor Author

ZhovnirMaria commented Apr 5, 2021

Thank you, @leslietilling, for your updates!

@ZhovnirMaria
Copy link
Contributor Author

Hi, @leslietilling
I made some changes to the request, you can check them.
Thank you!

@m2-community-project m2-community-project bot moved this from Review in Progress to Reviewer Approved in Pull Request Progress Apr 8, 2021
@dobooth dobooth moved this from Reviewer Approved to Acceptance Testing in Pull Request Progress Apr 9, 2021
@dobooth
Copy link
Contributor

dobooth commented Apr 9, 2021

@magento import code to magento-devdocs/merchdocs

@magento-engcom-team
Copy link

@dobooth the branch with code successfully imported intomagento-devdocs/merchdocs repository. Branch name: imported-magento-merchdocs-1110.

@magento-cicd2 magento-cicd2 merged commit 12f9b18 into magento:master Apr 9, 2021
@m2-community-project m2-community-project bot moved this from Acceptance Testing to Done in Pull Request Progress Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.4.x Changes for the Core 2.4.x release line, not patch specific Major update Significant new info: new section in existing topic, etc. Progress: done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants