Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading description of robots functionality #843

Merged
merged 3 commits into from Nov 10, 2020

Conversation

mpchadwick
Copy link
Contributor

@mpchadwick mpchadwick commented Nov 6, 2020

Magento does not use a physical file for robots.txt

Purpose of this pull request

This pull request (PR) ...

Magento release version

  • 2.4.x

    Specify a patch release number, if applicable:

  • 2.3.x

    Specify a patch release number, if applicable:

Product editions

Is this update specific to a product edition?

  • Magento Open Source only
  • Magento Commerce only

Is this update specific to an installed feature extension

  • B2B extension
  • Other feature set, please specify:

Affected documentation pages

  • ...
  • ...

Links to Magento source code or PRs

https://github.com/magento/magento2/blob/2.3.5-p2/app/code/Magento/Robots/Controller/Router.php#L59

Additional information

Magento does not use a physical file for robots.txt
Copy link
Contributor

@leslietilling leslietilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update, but need to remove link to code source directly from guide.

src/marketing/search-engine-robots.md Outdated Show resolved Hide resolved
Per review, the user guide shouldn't link to the code

Co-authored-by: Leslie Tilling <leslietilling@users.noreply.github.com>
@leslietilling leslietilling added Minor update Small improvements or additions to documentation 2.4.x Changes for the Core 2.4.x release line, not patch specific labels Nov 10, 2020
@m2-community-project m2-community-project bot moved this from Changes Requested to Reviewer Approved in Pull Request Progress Nov 10, 2020
@leslietilling leslietilling added the Community Apply this label to PRs for non-Adobe contributors label Nov 10, 2020
@leslietilling
Copy link
Contributor

running tests

@leslietilling leslietilling merged commit 7b6aaf0 into magento:master Nov 10, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.4.x Changes for the Core 2.4.x release line, not patch specific Community Apply this label to PRs for non-Adobe contributors Minor update Small improvements or additions to documentation Partner: Something Digital partners-contribution Progress: done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants