Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix tools and library graphic #1889

Merged
merged 3 commits into from Oct 15, 2019

Conversation

jcalcaben
Copy link
Contributor

Description

This PR update the graphic in the Tools and Library topic. It is causing confusion since Adobe Commerce Cloud does not support NodeJS which the graphic seems to imply.

Acceptance

@awilcoxa
@ericerway

Verification Stakeholders

@awilcoxa
@ericerway

Verification Steps

  1. Go to the pwa-devdocs directory: cd pwa-devdocs
  2. Build the html preview: npm run develop
  3. Verify the site builds
  4. Navigate to /technologies/tools-libraries/
  5. Verify new image is different from current: https://magento.github.io/pwa-studio/technologies/tools-libraries/

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@jcalcaben jcalcaben added pkg:pwa-devdocs documentation This pertains to documentation. version: Patch This changeset includes backwards compatible bug fixes. docs documentation labels Oct 14, 2019
@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Oct 14, 2019
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Oct 14, 2019

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or including the associated JIRA ID in your PR.

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against 2fb332e

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Oct 15, 2019
@dpatil-magento dpatil-magento moved this from Reviewer Approved to QA In Progress in Pull Request Progress Oct 15, 2019
@dpatil-magento dpatil-magento merged commit 31bacab into develop Oct 15, 2019
@dpatil-magento dpatil-magento deleted the jimothy/update-tools-library-diagram branch October 15, 2019 16:13
@m2-community-project m2-community-project bot moved this from QA In Progress to Done in Pull Request Progress Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation documentation This pertains to documentation. pkg:pwa-devdocs version: Patch This changeset includes backwards compatible bug fixes.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants