Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix]: Do not cache create customer or sign in mutation data #2176

Merged
merged 3 commits into from Feb 19, 2020

Conversation

@supernova-at
Copy link
Contributor

supernova-at commented Feb 19, 2020

Description

This PR modifies the create customer and sign in mutations to not cache. This way we don't keep PII around.

Related Issue

Closes PWA-380.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Fire up Venia and clear your application data and hard refresh
  2. View Apollo Cache via the Apollo extension or in local storage "apollo-cache-persist"
  3. Verify that the ROOT_MUTATION does not contain any PII
  4. Create a Customer
  5. Ensure Apollo Cache (ROOT_MUTATION entry) does not contain PII from create customer mutation

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.
@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Feb 19, 2020
@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Feb 19, 2020
@sirugh sirugh changed the title Do not cache create customer or sign in mutation data [bugfix]: Do not cache create customer or sign in mutation data Feb 19, 2020
Copy link
Contributor

sirugh left a comment

Our savior

@PWAStudioBot

This comment has been minimized.

Copy link
Collaborator

PWAStudioBot commented Feb 19, 2020

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PWA-380.

Generated by 🚫 dangerJS against f537d1c

@tjwiebell tjwiebell dismissed stale reviews from davemacaulay, jimbo, sirugh, revanth0212, and themself via f537d1c Feb 19, 2020
@sirugh
sirugh approved these changes Feb 19, 2020
Copy link
Contributor

sirugh left a comment

Our second savior

@dpatil-magento dpatil-magento merged commit c688af4 into develop Feb 19, 2020
6 checks passed
6 checks passed
AWS CodeBuild us-east-1 (pwa-pr-test) Build succeeded for project pwa-pr-test
Details
AWS CodeBuild us-east-1 (pwa-pull-request-build) Build succeeded for project pwa-pull-request-build
Details
AWS CodeBuild us-east-1 (pwa-pull-request-deploy) Build succeeded for project pwa-pull-request-deploy
Details
Adobe CLA Signed? ✓ Adobe (Magento) Employee
Details
Danger All green. Well done.
Details
coverage/coveralls First build on supernova/380_cache_pii at 66.071%
Details
@dpatil-magento dpatil-magento deleted the supernova/380_cache_pii branch Feb 19, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Feb 19, 2020
dpatil-magento added a commit that referenced this pull request Feb 19, 2020
* Do not cache create customer or sign in mutation data

* Ensure shipping and guest email is not persisted in cache

Co-authored-by: Tommy Wiebell <twiebell@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.