New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWA-2355 UPWARD JS resolver for Computed type #3533
PWA-2355 UPWARD JS resolver for Computed type #3533
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
async resolve() { | ||
debug('Computed resolver is meant for UPWARD PHP only.'); | ||
|
||
return ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't we be able to at least supply webpageChunks based on the page type similar to how the php implementation globs for those files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fooman Not without the page type information unfortunately. Each root component is its own chunk (sometimes more than one), and we only inline the chunks for the current page type.
Description
To bring the JS implementation of the UPWARD spec closer to the PHP implementation, we've added the Computed resolver to it as well. The resolver simply returns an empty string so the application can continue without error.
Related Issue
Closes PWA-2355
Acceptance
Verification Stakeholders
@zetlen
Specification
Changes to
upward-spec
and/orupward-js
packages must be reviewedVerification Steps
Test scenario(s) for direct fix/feature
DEBUG=upward-js:ComputedResolver yarn stage:venia
upward-js:ComputedResolver Computed resolver is meant for UPWARD PHP only
in the terminalTest scenario(s) for any existing impacted features/areas
INLINED_PAGE_TYPE
in browser console)Checklist
I have added translations for new strings, if necessary.