Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-2096: Track Checkout #3870

Merged
merged 5 commits into from Jun 3, 2022
Merged

PWA-2096: Track Checkout #3870

merged 5 commits into from Jun 3, 2022

Conversation

eug123
Copy link
Contributor

@eug123 eug123 commented May 27, 2022

Description

  1. "Shipping Information added" event is tracked whenever a user fills in their shipping information on the checkout page
  2. "Shipping method added" event is tracked whenever whenever a user fills in their shipping method on the checkout page
  3. "Billing information added" event is tracked whenever a user fills in their billing information on the checkout page
  4. "Review order" event is tracked whenever a user clicks the "review order" button on the checkout page
  5. "Place Order" and "Order confirmation page view" events are tracked whenever a user completes their order and sees the order confirmation page
  6. PlaceOrder Event includes the following attributes:
    • orderID
    • payments (paymentTransactionID, paymentAmount, paymentType, paymentCurrencyCode)
    • shipping (shippingMethod, shippingAmount)
    • promotionID
    • productArray
  7. Out of scope: coupon code, gift card, gift options
  8. Example extension subscribes to the events and has events available for processing

Added checkout related events:

  1. Shipping Information added/updated
    • CHECKOUT_SHIPPING_INFORMATION_ADDED
    • CHECKOUT_SHIPPING_INFORMATION_UPDATED
  2. Shipping method added/updated
    • CHECKOUT_SHIPPING_METHOD_ADDED
    • CHECKOUT_SHIPPING_METHOD_UPDATED
  3. Billing information added/updated
    • CHECKOUT_BILLING_INFORMATION_ADDED
    • CHECKOUT_BILLING_INFORMATION_UPDATED
  4. Review order button clicked event
    • CHECKOUT_REVIEW_BUTTON_CLICKED
  5. Place order button clicked event
    • CHECKOUT_PLACE_ORDER_BUTTON_CLICKED
  6. Order confirmation page view event was added in previous story - ORDER_CONFIRMATION_PAGE_VIEW

Related Issue

Closes #PWA-2096.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. With items in cart, go to the checkout page
  2. Fill out the shipping information and continue to next section
  3. Verify that the sample extension logged the shipping information added event (with its contextual data)
  4. Select the shipping method and continue to next section
  5. Verify that the sample extension logged the shipping method added event (with its contextual data)
  6. Fill out the billing method and address and continue to the next section
  7. Verify that the sample extension logged the billing information added event (with its contextual data)
  8. Click on Review order button
  9. Edit shipping address, metho, and billing info and enter new information
  10. For each edit, verify the sample extension logged the appropriate event with the correct data
  11. Click on Place Order Button
  12. Verify these steps for both Guest and Registered users.
  13. Verify these steps for the zero checkout flow, i.e. using a gift card that exceeds total cost so you pay "zero" at checkout

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@eug123 eug123 marked this pull request as ready for review May 27, 2022 14:08
@eug123 eug123 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label May 27, 2022
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented May 27, 2022

Messages
📖

Associated JIRA tickets: PWA-2096.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against be8f202

@eug123
Copy link
Contributor Author

eug123 commented May 27, 2022

run all tests

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 27, 2022

Successfully started codebuild job for the following test suites:

pr-test
scaffold-pwa
cypress
lighthouse-desktop
lighthouse-mobile

@eug123
Copy link
Contributor Author

eug123 commented May 27, 2022

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 27, 2022

Successfully started codebuild job for cypress

michaelyu0123
michaelyu0123 previously approved these changes Jun 1, 2022
@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 2, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor

dpatil-magento commented Jun 2, 2022

@eug123 Please check following -

  1. Auth user > Shipping information update event is not triggered if user just updates Shipping information before even applying on below screen.

image

  1. When Auth user place a first order and again tries to place second order >> In this Shipping information and Shipping method both pre-populated. Currently Shipping information Added and Shipping Method Added events are not tracked. Hope this is expected.

@eug123
Copy link
Contributor Author

eug123 commented Jun 3, 2022

@dpatil-magento,

  1. Added USER_ADDRESS_CREATE and USER_ADDRESS_EDIT events when registered customer adds/edits address in the address book, without updating shipping information
  2. Event should be dispatched when user performs action, when shipping information is available and is pre-populated it is added to checkout automatically without user action

Thank you!

@eug123
Copy link
Contributor Author

eug123 commented Jun 3, 2022

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 3, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 3, 2022

Successfully started codebuild job for cypress

@dpatil-magento
Copy link
Contributor

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 3, 2022

Successfully started codebuild job for lighthouse-desktop

@dpatil-magento
Copy link
Contributor

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 3, 2022

Successfully started codebuild job for lighthouse-mobile

@dpatil-magento
Copy link
Contributor

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 3, 2022

Successfully started codebuild job for lighthouse-desktop

@dpatil-magento dpatil-magento merged commit a7b78fb into develop Jun 3, 2022
@dpatil-magento dpatil-magento deleted the PWA-2096 branch June 3, 2022 18:19
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants