From af678f06f8ec1518b42f9eec367772b8b1ac2727 Mon Sep 17 00:00:00 2001
From: Jonathan Stein <jonathanstein@live.com>
Date: Mon, 3 Dec 2018 15:10:36 -0800
Subject: [PATCH 1/3] fix navigation sidebar being too wide for some phones,
 fix bug which caused back method/titles on nav to be wrong after creating
 account and signing in

---
 .../CreateAccount/createAccount.css           |  2 +-
 .../src/components/Navigation/navigation.css  |  4 ++-
 .../src/components/Navigation/navigation.js   | 36 +++++++++++--------
 .../src/components/SignIn/signIn.css          |  2 +-
 4 files changed, 27 insertions(+), 17 deletions(-)

diff --git a/packages/venia-concept/src/components/CreateAccount/createAccount.css b/packages/venia-concept/src/components/CreateAccount/createAccount.css
index 06c942fc04..afbcb3e646 100644
--- a/packages/venia-concept/src/components/CreateAccount/createAccount.css
+++ b/packages/venia-concept/src/components/CreateAccount/createAccount.css
@@ -1,6 +1,6 @@
 .createAccountButton {
     text-align: center;
-    margin-top: 2em;
+    margin: 1rem 0;
 }
 
 .rewards {
diff --git a/packages/venia-concept/src/components/Navigation/navigation.css b/packages/venia-concept/src/components/Navigation/navigation.css
index 6a3b9ae3da..54a1862024 100644
--- a/packages/venia-concept/src/components/Navigation/navigation.css
+++ b/packages/venia-concept/src/components/Navigation/navigation.css
@@ -12,7 +12,8 @@
     transition-timing-function: cubic-bezier(0.4, 0, 1, 1);
     transition-property: opacity, transform, visibility;
     visibility: hidden;
-    width: 360px;
+    width: 100%;
+    max-width: 360px;
     z-index: 3;
 }
 
@@ -85,6 +86,7 @@
     position: absolute;
     right: 0;
     top: 0;
+    overflow-y: auto;
 }
 
 .signIn_open {
diff --git a/packages/venia-concept/src/components/Navigation/navigation.js b/packages/venia-concept/src/components/Navigation/navigation.js
index bbfe863176..3ca02ffc34 100644
--- a/packages/venia-concept/src/components/Navigation/navigation.js
+++ b/packages/venia-concept/src/components/Navigation/navigation.js
@@ -205,23 +205,31 @@ class Navigation extends PureComponent {
         } = this;
 
         const { isCreateAccountOpen, isSignInOpen, rootNodeId } = state;
-        const { classes, closeDrawer, isOpen, rootCategoryId } = props;
+        const {
+            classes,
+            closeDrawer,
+            isOpen,
+            rootCategoryId,
+            isSignedIn
+        } = props;
         const className = isOpen ? classes.root_open : classes.root;
         const isTopLevel = !rootNodeId || rootNodeId === rootCategoryId;
 
-        const handleBack = isCreateAccountOpen
-            ? hideCreateAccountForm
-            : isSignInOpen
-            ? hideSignInForm
-            : isTopLevel
-            ? closeDrawer
-            : setRootNodeIdToParent;
-
-        const title = isCreateAccountOpen
-            ? 'Create Account'
-            : isSignInOpen
-            ? 'Sign In'
-            : 'Main Menu';
+        const handleBack =
+            isCreateAccountOpen && !isSignedIn
+                ? hideCreateAccountForm
+                : isSignInOpen && !isSignedIn
+                ? hideSignInForm
+                : isTopLevel
+                ? closeDrawer
+                : setRootNodeIdToParent;
+
+        const title =
+            isCreateAccountOpen && !isSignedIn
+                ? 'Create Account'
+                : isSignInOpen && !isSignedIn
+                ? 'Sign In'
+                : 'Main Menu';
 
         return (
             <aside className={className}>
diff --git a/packages/venia-concept/src/components/SignIn/signIn.css b/packages/venia-concept/src/components/SignIn/signIn.css
index e37851f9db..be969af298 100644
--- a/packages/venia-concept/src/components/SignIn/signIn.css
+++ b/packages/venia-concept/src/components/SignIn/signIn.css
@@ -8,7 +8,7 @@
 .signInButton,
 .showCreateAccountButton {
     text-align: center;
-    margin: 1rem 0 0;
+    margin: 1rem 0;
 }
 
 .forgotPassword {

From 01864127687652c5247432eb243dcd6a8f94437b Mon Sep 17 00:00:00 2001
From: Jonathan Stein <jonathanstein@live.com>
Date: Wed, 5 Dec 2018 05:37:34 -0800
Subject: [PATCH 2/3] alphabetize consts

---
 packages/venia-concept/src/components/Navigation/navigation.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/venia-concept/src/components/Navigation/navigation.js b/packages/venia-concept/src/components/Navigation/navigation.js
index 3ca02ffc34..049f665565 100644
--- a/packages/venia-concept/src/components/Navigation/navigation.js
+++ b/packages/venia-concept/src/components/Navigation/navigation.js
@@ -209,8 +209,8 @@ class Navigation extends PureComponent {
             classes,
             closeDrawer,
             isOpen,
+            isSignedIn,
             rootCategoryId,
-            isSignedIn
         } = props;
         const className = isOpen ? classes.root_open : classes.root;
         const isTopLevel = !rootNodeId || rootNodeId === rootCategoryId;

From c436b404b3ee5551886e29e4d35be432c83d74c1 Mon Sep 17 00:00:00 2001
From: Jonathan Stein <jonathanstein@live.com>
Date: Wed, 5 Dec 2018 05:41:28 -0800
Subject: [PATCH 3/3] prettier pass

---
 packages/venia-concept/src/components/Navigation/navigation.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/venia-concept/src/components/Navigation/navigation.js b/packages/venia-concept/src/components/Navigation/navigation.js
index 049f665565..2f84b9c24b 100644
--- a/packages/venia-concept/src/components/Navigation/navigation.js
+++ b/packages/venia-concept/src/components/Navigation/navigation.js
@@ -210,7 +210,7 @@ class Navigation extends PureComponent {
             closeDrawer,
             isOpen,
             isSignedIn,
-            rootCategoryId,
+            rootCategoryId
         } = props;
         const className = isOpen ? classes.root_open : classes.root;
         const isTopLevel = !rootNodeId || rootNodeId === rootCategoryId;