From 58254115cc259163b099de0c01911bac596b57cc Mon Sep 17 00:00:00 2001 From: Pavel Bystritsky Date: Tue, 10 Mar 2020 13:04:27 +0200 Subject: [PATCH] security-package/issues/132: $validationErrors is undefined in \Magento\ReCaptchaValidation\Model\Validator --- ReCaptchaValidation/Model/Validator.php | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/ReCaptchaValidation/Model/Validator.php b/ReCaptchaValidation/Model/Validator.php index 116468ed..a770a5da 100644 --- a/ReCaptchaValidation/Model/Validator.php +++ b/ReCaptchaValidation/Model/Validator.php @@ -60,14 +60,13 @@ public function isValid( } $result = $reCaptcha->verify($reCaptchaResponse, $validationConfig->getRemoteIp()); - if ($result->isSuccess()) { - $validationResult = $this->validationResultFactory->create(['errors' => []]); - } else { + $validationErrors = []; + if (!$result->isSuccess()) { foreach ($result->getErrorCodes() as $errorCode) { $validationErrors[] = $this->errorMessages->getErrorMessage($errorCode); } - $validationResult = $this->validationResultFactory->create(['errors' => $validationErrors]); } - return $validationResult; + + return $this->validationResultFactory->create(['errors' => $validationErrors]); } }