Refactoring. #146
Merged
Refactoring. #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
✔️ QA passed |
engcom-Foxtrot
added
the
Component: Google reCAPTCHA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/magento/security-package/blob/1.0-develop/ReCaptchaValidationApi/Model/ErrorMessages.php#L8 it does not look like a Model but more like service class
A factory should be used instead of
newto provide a mocking mechanism for tests https://github.com/magento/security-package/blob/1.0-develop/ReCaptchaValidation/Model/Validator.php#L54https://github.com/magento/security-package/blob/1.0-develop/ReCaptchaValidation/Model/Validator.php#L63-L69 could be simplified -> create validation errors array and after that create a result object
https://github.com/magento/security-package/blob/1.0-develop/ReCaptchaCustomer/Model/AjaxLogin/CaptchaResponseResolver.php#L35 incorrect doc block formatting