From 4fbfde213f860bac2487ebc2aa6e806f655b8019 Mon Sep 17 00:00:00 2001 From: Matt Walters Date: Mon, 7 Sep 2020 16:35:04 +0100 Subject: [PATCH] magento/security-package#269: Browser Shouldn't Suggest Historic 2FA Codes - Adding `[autocomplete="off"]` for Affected Fields - Minor Refactoring --- TwoFactorAuth/view/adminhtml/web/template/authy/auth.html | 3 ++- .../view/adminhtml/web/template/authy/configure/verify.html | 1 + TwoFactorAuth/view/adminhtml/web/template/google/auth.html | 3 ++- .../view/adminhtml/web/template/google/configure.html | 3 ++- 4 files changed, 7 insertions(+), 3 deletions(-) diff --git a/TwoFactorAuth/view/adminhtml/web/template/authy/auth.html b/TwoFactorAuth/view/adminhtml/web/template/authy/auth.html index 9b9a0029..f4ee0818 100644 --- a/TwoFactorAuth/view/adminhtml/web/template/authy/auth.html +++ b/TwoFactorAuth/view/adminhtml/web/template/authy/auth.html @@ -70,8 +70,9 @@

id="tfa_code" class="admin__control-text" type="text" + autocomplete="off" data-bind='{value: tokenCode, enable: !waitingText()}' - placeholder="Your code" /> + placeholder="Your code"/> diff --git a/TwoFactorAuth/view/adminhtml/web/template/authy/configure/verify.html b/TwoFactorAuth/view/adminhtml/web/template/authy/configure/verify.html index eaaef771..a4a7a71d 100644 --- a/TwoFactorAuth/view/adminhtml/web/template/authy/configure/verify.html +++ b/TwoFactorAuth/view/adminhtml/web/template/authy/configure/verify.html @@ -24,6 +24,7 @@ id="tfa_authy_verify" class="admin__control-text" type="text" + autocomplete="off" autofocus placeholder="Verification code"/> diff --git a/TwoFactorAuth/view/adminhtml/web/template/google/auth.html b/TwoFactorAuth/view/adminhtml/web/template/google/auth.html index 796bc3bf..62b908d5 100644 --- a/TwoFactorAuth/view/adminhtml/web/template/google/auth.html +++ b/TwoFactorAuth/view/adminhtml/web/template/google/auth.html @@ -22,8 +22,9 @@ id="tfa_code" class="admin__control-text" type="text" + autocomplete="off" autofocus - placeholder="Your code'"/> + placeholder="Your code"/> diff --git a/TwoFactorAuth/view/adminhtml/web/template/google/configure.html b/TwoFactorAuth/view/adminhtml/web/template/google/configure.html index 759e26be..87bc61c8 100644 --- a/TwoFactorAuth/view/adminhtml/web/template/google/configure.html +++ b/TwoFactorAuth/view/adminhtml/web/template/google/configure.html @@ -28,8 +28,9 @@ id="tfa_code" class="admin__control-text" type="text" + autocomplete="off" autofocus - placeholder="Your code'"/> + placeholder="Your code"/>