Skip to content

Feat/remember settings 101#752

Open
aksharsawhney74-rgb wants to merge 14 commits into
magic-peach:mainfrom
aksharsawhney74-rgb:feat/remember-settings-101
Open

Feat/remember settings 101#752
aksharsawhney74-rgb wants to merge 14 commits into
magic-peach:mainfrom
aksharsawhney74-rgb:feat/remember-settings-101

Conversation

@aksharsawhney74-rgb
Copy link
Copy Markdown
Contributor

This PR adds the ability for users to persist their export settings across sessions. I wired up localStorage inside the useVideoEditor hook to save and load the EditRecipe whenever the new "Remember settings" toggle is active.

As part of this, I also took the opportunity to build a clean, reusable Toggle UI component using tailwind-merge and clsx so we can easily use switches elsewhere in the app down the line.

Closes #101

@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

@aksharsawhney74-rgb is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @aksharsawhney74-rgb!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added level:advanced Advanced level - 55 pts type:design UI/UX design labels May 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

⚠️ PR Format Issues — @aksharsawhney74-rgb

Please fix the following before your PR can be reviewed:

  • ⚠️ Use a conventional PR title. Examples:
    • feat: add dark mode support
    • fix: resolve aria label missing on slider
    • docs: add deployment guide to README

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

@github-actions github-actions Bot added the level:intermediate Intermediate level - 35 pts label May 19, 2026
@magic-peach
Copy link
Copy Markdown
Owner

@aksharsawhney74-rgb please resolve conflicts

@magic-peach magic-peach added type:feature New feature gssoc'26 GirlScript Summer of Code 2026 labels May 21, 2026
@magic-peach
Copy link
Copy Markdown
Owner

Hey @aksharsawhney74-rgb! The build, lint, and typecheck checks are all failing on this PR. Please fix the errors locally (bun run build && bun run lint && bunx tsc --noEmit) before pushing.

@magic-peach magic-peach removed the level:intermediate Intermediate level - 35 pts label May 23, 2026
@magic-peach
Copy link
Copy Markdown
Owner

Hey @aksharsawhney74-rgb! CI is failing on this PR — here's what needs to be fixed.

Failing checks: lint, typecheck, build (and Vercel downstream)

Root cause: There's a syntax error in src/app/page.tsx that breaks the entire build:

src/app/page.tsx(20,7): error TS1003: Identifier expected.
build: Error — Expression expected in src/app/page.tsx

This typically means there's invalid JavaScript/TypeScript syntax — like a stray character, an incomplete expression, or a merge conflict marker left in the file.

How to fix:

  1. Open src/app/page.tsx and look at line 20 — there's a syntax error there.
  2. Check for: stray characters, incomplete expressions, missing identifiers, or accidental merge conflict markers (<<<<<<<, =======, >>>>>>>).
  3. Fix the syntax so the file is valid TypeScript/JSX.
  4. Run bunx tsc --noEmit and bun run build locally to confirm both pass.

Also note: PR #838 ("feat: persist editor settings to localStorage") was merged into main on May 21, covering similar "remember settings" functionality. Please rebase your branch on main first — there may be significant overlap with what's already in the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts type:design UI/UX design type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Add 'Remember settings' toggle to persist recipe across sessions

2 participants