Use user specified ruby installation path instead of defaulting to homebrew installation. #117

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@awmwong
awmwong commented Dec 21, 2011

Not everyone has their ruby installed by Homebrew, or that specific version. The env utility invokes the ruby that is first in the users PATH. This will allow people who don't have ruby installed by homebrew to build MR.

Anthony Wong Modified ruby script to grab the ruby path from env instead of always…
… looking for a homebrew installation in Cellar
b85a839
@gregfu
gregfu commented on b85a839 Dec 26, 2011

This assumes env points to 1.9 version of ruby. The code in the processor is ruby 1.9 specific.

@gregfu The previous line assumes that the user has used Homebrew to install version 1.9.2-p290 of ruby. I think that is a far worse assumption than assuming that users have ruby 1.9 in their path.

The old assumption prevents users from using rvm or rbenv to manage their ruby installs and it prevents users from using another version of ruby 1.9.x. I think forcing contributors to have homebrew and that specific version of ruby makes it difficult to contribute to MR.

A better solution would be using the RUBY_VERSION string to inform users that they need ruby 1.9+ to build MR or simply documenting this in the documentation.

This allows people who have installed other versions of ruby 1.9.x and through other means to actually build MR. I think changing the interpreter path is the only way of doing this. Using env to invoke the interpreter is standard practice.

@blackgold9
Member

Resolved this in the latest commit

@blackgold9 blackgold9 closed this Sep 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment