Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added static library and framework targets. #126

Closed
wants to merge 14 commits into
from

Conversation

Projects
None yet
3 participants

dodikk commented Jan 3, 2012

No description provided.

@ghost
Owner

dodikk replied Jan 3, 2012

Sorry for my poor English. But I haven't understood the idea of your post.

Here are my reasons for objc_msgSend usage :

  1. I don't know your codebase good enough to re-implement this piece in block style or any other fashion.
  2. Hovever, "objc_msgSend" legally removes annoying warnings and does not significantly change your logic.

ghost replied Jan 3, 2012

Owner

dodikk replied Jan 3, 2012

It's a subtle difference, but I truly do not like mixing 2 programming paradigms in the same method.
I agree. But I don't like compiler warnings even more and use -WError.

In the project's readme you claim to support both ARC and non-ARC compilers.
I use only ARC target in my fork because it uses a newer runtime and generates less compiler warnings. Your source code has not been changed (except of those warning related workarounds). The only difference is "CLANG_ENABLE_OBJC_ARC = YES" flag in the respective target.

You can create a separate target for retain/release style. Just copy my library and framework targets and set "CLANG_ENABLE_OBJC_ARC = NO".
I'll do it as soon as I have some spare time.

Member

blackgold9 commented Sep 13, 2012

I'm closing this due to bit-rot over 8 months. I do think it's worthwhile to do however. Will get to it.

@blackgold9 blackgold9 closed this Sep 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment