Warnings fix #131

Closed
wants to merge 11 commits into from

2 participants

@dav

I run pretty strict warnings so fixed these to get clean. The second one should be fine, not as certain about the first one (the block local var shadowing) so you might want to take a closer look at that to be sure.

NSManagedObject+MagicalDataImport.m:242:81: warning: declaration shadows a local variable [-Wshadow,3]
NSObject+MagicalDataImport.m: warning: comparison of integers of different signs: 'int' and 'const NSUInteger' (aka 'const unsigned int') [-Wsign-compare,3]

dav added some commits Jan 16, 2012
@dav dav DIY: update to fix compiler warnings
NSManagedObject+MagicalDataImport.m:242:81: warning: declaration shadows a local variable [-Wshadow,3]
NSObject+MagicalDataImport.m: warning: comparison of integers of different signs: 'int' and 'const NSUInteger' (aka 'const unsigned int') [-Wsign-compare,3]
ff898d3
@dav dav DIY: Replaced performSelectorOnMainThread with my usual method, as I …
…was getting deadlocks I couldn't track down and just wanted to make sure this wasn't part of the problem. Voodoo, perhaps.

See also http://stackoverflow.com/a/5226271/426608
b200697
@dav dav DIY: force using pre-iOS5 style thread handling a6e6d7f
@dav dav DIY: adding a bit of debugging info for now c76a05f
@dav dav DIY: fix a couple of CLANG warnings ea970a2
@dav dav DIY: Adding orginal lines commented out in case I rollback manually l…
…ater
bcba846
@dav dav DIY: Was crashing in XCode4.2 and 5.0 simulator. This nil check seems…
… to fix it.

Wish I had time to dig deeper.
3069938
@dav dav Merge remote-tracking branch 'reference/master'
Conflicts:
	Source/Categories/NSManagedObject+MagicalDataImport.m
991c82b
@dav dav DIT: Don't use Three20 stuff in a different external project. 6ce1a2c
@dav dav DIY: added nil check
Refs: I think there was a crash prompting this fix, but made the change weeks ago and forgot to check in so not sure. Doh.
1d1af94
@dav dav Merge branch 'master' of github.com:dav/MagicalRecord
Conflicts:
	Source/Categories/NSPersistentStore+MagicalRecord.m
4d3d1bd
@blackgold9 blackgold9 was assigned Sep 23, 2012
@blackgold9
Magical Panda Software member

These changes are very out of date now, so I'm closing this, and will take a warnings pass through the code.

@blackgold9 blackgold9 closed this Sep 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment