Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[NSManagedObjectContext MR_saveInBackgroundErrorHandler:completion:] #202

merged 2 commits into from Jul 8, 2012


None yet
3 participants

jwie commented Jul 6, 2012

  • Only dispatch completion handler when it's not nil.
  • Wait for the block to complete.

Jwie added some commits Jul 6, 2012

Jwie [NSManagedObjectContext MR_saveInBackgroundErrorHandler:completion:]
- Only dispatch completion handler when it's not nil.
Jwie [NSManagedObjectContext MR_saveInBackgroundErrorHandler:completion:]
- Wait for the block to complete.

The current implementation in magical record produces a crash on its second call to dispatch. Please include this pull request for the dispatch handler.

On the other hand why wait on the block? its supposed to be saved in the background.

@casademora casademora added a commit that referenced this pull request Jul 8, 2012

@casademora casademora Merge pull request #202 from jwie/fix_unit_test
[NSManagedObjectContext MR_saveInBackgroundErrorHandler:completion:]

@casademora casademora merged commit e117ead into magicalpanda:master Jul 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment