Skip to content

Bad model cleanup #238

Merged
merged 5 commits into from Sep 6, 2012

2 participants

@blackgold9
Magical Panda Software member

This code deletes the store when it finds a mismatched store/model. Configurable in MagicalRecord+options

@blackgold9
Magical Panda Software member

On by default (Set in initialize). I can't think of any situation in which I'd want to NOT delete the store on a model mismatch .

@casademora
Magical Panda Software member
@casademora
Magical Panda Software member

can you post a short 1-2 sentence blurb in the read me also?

@blackgold9
Magical Panda Software member

The alternative is your app loads completely blank in production. I think I'd rather it function...
That said, I've written mostly consumption oriented apps so far, nothing where the user has put in hours of work creating data. I could see that being the wrong choice for some apps.

My take is that Magical Record aims to be simple and "just work" wherever possible, and having it recover from the developer adding a field and forgetting to version seems to fit that ideal. I'm not married to it though.

@casademora
Magical Panda Software member
@blackgold9
Magical Panda Software member

Ad-Hoc builds use release configuration by default (no debug flag). In that case, beta users will still need to uninstall/re-install with every model change (or the developer will have to create a ton of model versions).
The other option is having the user just set the option themselves for ad-hoc builds. Not horrible I guess.
Thoughts?

@casademora
Magical Panda Software member
@blackgold9
Magical Panda Software member

Done

@blackgold9 blackgold9 merged commit 79e08e9 into magicalpanda:master Sep 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.