saveWithBlock was not saving parent contexts #281

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

tonyarnold commented Oct 16, 2012

This makes the saveWithBlock method consistent with it's background
siblings.

tonyarnold added some commits Oct 16, 2012

saveWithBlock was not saving parent contexts
This makes the saveWithBlock method consistent with it's background
siblings.
Owner

casademora commented Oct 16, 2012

Sweet, thanks for including a unit test :)

Contributor

tonyarnold commented Oct 16, 2012

No problems, @casademora — I've been talking to @blackgold9 about this fix, and I'm reasonably sure it's OK (it fixed the issue I was seeing with the synchronous call), but it probably needs a once over to make sure that the performBlock: calls aren't going to deadlock or anything silly like that.

Member

blackgold9 commented Oct 16, 2012

Merged via patch

@blackgold9 blackgold9 closed this Oct 16, 2012

Contributor

tonyarnold commented Nov 18, 2012

@blackgold9 — could you not merge via patches in future? My fork is invalidated now, and any future pull requests I've tried to make include all kinds of merge cruft. I need to destroy my fork and start over 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment