Incorrect date timezone assumption while importing #360

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

madninja commented Jan 2, 2013

The server returns data using GMT ("Zulu"-time). Setting the formatter's timezone to local adjusts the time to the local time which results in an incorrect date.

This was also failing the unit test. This fixes the basic bug. A slightly larger feature/fix could allow adjusting the timezone by allowing a timeZone attribute in the data model.

Marc Nijdam Incorrect date timezone assumption while importing
The server returns data using GMT ("Zulu"-time). Setting the formatter's timezone to local adjusts the time to the local time which results in an incorrect date.

This was also failing the unit test. This fixes the basic bug. A slightly larger feature/fix could allow  adjusting the timezone by allowing a timeZone attribute in the data model.
949eb07
Contributor

tonyarnold commented Jan 2, 2013

Hi @madninja, thanks! Would you please resubmit this pull request against the development branch?

madninja commented Jan 3, 2013

Urgh.. I fixed it on a branch of develop and thought I did.. Not sure what happened.

madninja closed this Jan 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment