Externally exposing the lookupKey/relatedByAttribute #396

Closed
wants to merge 10 commits into
from

Conversation

Projects
None yet
2 participants

stuffmc commented Jan 24, 2013

Allows to use it like [[MyEntity entityDescription] lookupKey] — Maybe we could call this relatedByAttribute and move it to CoreData+MagicalRecord.h as a class method.

stuffmc added some commits Jan 24, 2013

Externally exposing the lookupKey to use it like `[[MyEntity entityDe…
…scription] lookupKey]` (Maybe we could call this `relatedByAttribute` and move it to `CoreData+MagicalRecord.h` as a class method.
Passing a ManagedObject to MR_importFromObject: allows to "duplicate"…
… that Object like with a NSDictionary. Skipping relationships in this case.
Contributor

tonyarnold commented Jan 26, 2013

Looks good to me — thanks for fixing up the stylistic things, @stuffmc! We should remember to add MR_lookupKey to the shorthand header, too.

stuffmc commented Jan 26, 2013

Oh, wow. So this is the way Pull Requests works? Everytime I'll add something in my branch stuffmc you guys will get noticed? That's "interesting" — Now that I know that Maybe I should push to "my" experimental and when there are things I don't want to be merged here (or in dev for example).

Contributor

tonyarnold commented Jan 26, 2013

Generally, the best approach is to create "feature branches". Basically, make discrete changes, create a new branch for each of them. Related changes are OK, but getting a whole swag of unrelated code to review is no fun.

Have a read of A successful Git branching model — this is how we have been working for the last couple of months with MR, and it's how we'd prefer to receive changes and pull requests.

That all said, any method of contribution is welcome and if there's merit in what you've done (even if it's a mega messy pull request) we might still cherry pick out the individual changes we want to merge.

Contributor

tonyarnold commented Apr 8, 2014

Given the age of this issue, and the volume of issues we have to work through, I've decided to close this alongside a number of other older issues.

If you can still replicate the issue under the latest in-development version of MagicalRecord (3.0 at the time of writing), please feel free to re-open and one of @magicalpanda/team-magicalrecord will take another look. Thanks!

@tonyarnold tonyarnold closed this Apr 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment