Update defaultLocalStoreUrl to use defaultStoreName #585

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@l4u

l4u commented Oct 10, 2013

[MagicalRecord setupCoreDataStack] uses [MagicalRecord defaultStoreName]
While the NSPersistentStore category is using the old constant.

For example, when kCFBundleNameKey exists.
[MagicalRecord setupCoreDataStack] creates the database at {kCFBundleNameKey}.sqlite
but [NSPersistentStore MR_defaultLocalStoreUrl] returns the old fallback file name CoreDataStore.sqlite

Some tests are in Needs porting, what tests do you prefer?

Update defaultLocalStoreUrl to use defaultStoreName
[MagicalRecord setupCoreDataStack] uses [MagicalRecord defaultStoreName]
While the NSPersistentStore category is using the old constant.
@tonyarnold

This comment has been minimized.

Show comment Hide comment
@tonyarnold

tonyarnold Apr 8, 2014

Contributor

This code has been rewritten for the upcoming MagicalRecord 3 release. Thanks for your PR!

Contributor

tonyarnold commented Apr 8, 2014

This code has been rewritten for the upcoming MagicalRecord 3 release. Thanks for your PR!

@tonyarnold tonyarnold closed this Apr 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment