Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Potential fix to issue #644 #645

Closed
wants to merge 2 commits into from

2 participants

@eflath

import callbacks must return a BOOL indicating whether they have handled the import themselves (YES) or whether MR still needs to handle it (NO). the default is YES for backwards compatibility.

Evan Flath honor the return value of import<attribute> methods
import callbacks must return a BOOL indicating whether they have handled the import themselves (YES) or whether MR still needs to handle it (NO). the default is YES for backwards compatibility.
616e53a
@tonyarnold
Owner

Fixed by d861127. Thanks!

@tonyarnold tonyarnold closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 9, 2014
  1. honor the return value of import<attribute> methods

    Evan Flath authored
    import callbacks must return a BOOL indicating whether they have handled the import themselves (YES) or whether MR still needs to handle it (NO). the default is YES for backwards compatibility.
  2. remove superfluous comments

    Evan Flath authored
This page is out of date. Refresh to see the latest.
View
5 MagicalRecord/Categories/NSManagedObject/NSManagedObject+MagicalDataImport.m
@@ -42,8 +42,9 @@ - (BOOL) MR_importValue:(id)value forKey:(NSString *)key
[invocation setSelector:selector];
[invocation setArgument:&value atIndex:2];
[invocation invoke];
-// [self performSelector:selector withObject:value];
- return YES;
+ BOOL returnValue = YES;
+ [invocation getReturnValue:&returnValue];
+ return returnValue;
}
return NO;
}
Something went wrong with that request. Please try again.