Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added support for boolean attribute provided as a string in data source #680

Merged
merged 1 commit into from Feb 18, 2014

Conversation

Projects
None yet
2 participants
Contributor

JRG-Developer commented Feb 18, 2014

Added support for booleanAsStringTestAttribute. That is, where the desired attribute type is NSBooleanAttributeType yet the data source is a string value.

(This may not be commonly encountered with JSON-formatted data sources, but it's very possible if the format is XML or PLIST).

On the current, latest develop commit, this event typically (and in my experience, always) results in the app crashing during MagicalRecord importing.

Also added a test for the new behavior.
All tests passing.

Add support for `booleanAsStringTestAttribute` (where the attribute t…
…ype is `boolean` yet the data source is a string value).

Prior to this patch, this would cause a crash if encountered.
Also added a test for the new behavior.
All tests pass.

casademora added a commit that referenced this pull request Feb 18, 2014

Merge pull request #680 from JRG-Developer/Add_Support_For_Boolean_As…
…_String

Added support for boolean attribute provided as a string in data source

@casademora casademora merged commit 98ec121 into magicalpanda:develop Feb 18, 2014

1 check passed

default The Travis CI build passed
Details

@JRG-Developer JRG-Developer deleted the JRG-Developer:Add_Support_For_Boolean_As_String branch Feb 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment