Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root-toast depends on root-siblings, and root-siblings version is not compatible with React Native v0.48 #44

Closed
KhalilKhalaf opened this issue Sep 8, 2017 · 14 comments

Comments

@KhalilKhalaf
Copy link

KhalilKhalaf commented Sep 8, 2017

So related to #41, but more english in it.

root-toast has a dependency: root-siblings

screen shot 2017-09-08 at 3 53 55 pm

root-siblings' version is not compatible with any higher React Native versions (I am currently on 0.45 for this to work)

I need to upgrade RN so that other dependencies behave properly, but in order to do that, I will have to wipe out root-toast entirely.

@KhalilKhalaf KhalilKhalaf changed the title root-toast depends on root-siblings, and root-siblings version is not compatible with React Native to v0.48 root-toast depends on root-siblings, and root-siblings version is not compatible with React Native v0.48 Sep 8, 2017
@fuxianwei
Copy link

+1

2 similar comments
@nfplay
Copy link

nfplay commented Sep 10, 2017

+1

@DavidKongDesheng
Copy link

+1

@cooliean
Copy link

cooliean commented Sep 11, 2017

Temporary solution:
Modify node_modules/react-native-root-siblings/lib/AppRegistryInjection.js

//import EventEmitter from 'react-native/Libraries/EventEmitter/EventEmitter';
import EventEmitter from 'react-native/Libraries/vendor/emitter/EventEmitter'

This version of RN moves the location of the emitter package

@baijunjie
Copy link

+1

1 similar comment
@cbjs
Copy link

cbjs commented Sep 11, 2017

+1

@willbattel
Copy link

+2

@delia-m
Copy link

delia-m commented Sep 11, 2017

+1

1 similar comment
@JoostVermeulen11
Copy link

+1

@t407289575
Copy link

t407289575 commented Sep 20, 2017

@alex-gunning
Copy link

+1

1 similar comment
@EyalSi
Copy link

EyalSi commented Sep 27, 2017

+1

@JingLiangWen
Copy link

+1

@magicismight
Copy link
Owner

This has been fixed in 2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests