feat: add startValue prop to number-ticker component#428
feat: add startValue prop to number-ticker component#428PraveenShinde3 wants to merge 1 commit intomagicuidesign:mainfrom
Conversation
|
@PraveenShinde3 is attempting to deploy a commit to the product-studio Team on Vercel. A member of the Team first needs to authorize it. |
|
So far, I have only made changes to |
|
Do you think this prop is essential to add, and why? The main goal of a ticker number component is to display an animated number until it reaches the specified value. Adding an extra prop that doesn't make a significant difference might not be necessary, in my opinion. |
I think it actually is based off how your using it.. If you have multiple for example a stats component and one of your numbers is high and isn't truncated to a localized format, you encounter situations where some numbers in a sequence complete their animation much earlier than others. For example, smaller numbers will quickly finish ticking, while larger numbers will have to cycle through thousands very rapidly to catch up. This can look visually unappealing or "weird." I have manually done this myself previously as its a more synchronized effect, making the animation feel more balanced, regardless of the values. |
|
Thank you for the suggestion. We have merged it into this PR #578 and we are closing this PR on its behalf. |
Pull Request: Add startValue Prop to NumberTicker Component
This PR introduces a new startValue prop for the NumberTicker component. The startValue prop allows users to set an initial value for the number displayed by the component.
Demo video
Screen.Recording.2024-11-29.205216.mp4
Related Issue
Closes #426